Fix signature of writeGuestbookAndStartFileDownload in xhtml#12252
Fix signature of writeGuestbookAndStartFileDownload in xhtml#12252
Conversation
stevenwinship
moved this from In Progress 💻
to Ready for Review ⏩
in IQSS Dataverse Project
| actionListener="#{fileDownloadService.writeGuestbookAndStartFileDownload(guestbookResponse, fileMetadata, 'var')}"> | ||
| actionListener="#{fileDownloadService.writeGuestbookAndStartFileDownload(guestbookResponse, fileMetadata, 'var', null)}"> | ||
| #{bundle['file.downloadBtn.format.var']} | ||
| </p:commandLink> |
There was a problem hiding this comment.
I'm just noting that https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-12252/2/consoleFull failed with something unrelated:
TASK [dataverse : Wait until localstack status is ready] ***********************
FAILED - RETRYING: [localhost]: Wait until localstack status is ready (18 retries left).
FAILED - RETRYING: [localhost]: Wait until localstack status is ready (17 retries left).
FAILED - RETRYING: [localhost]: Wait until localstack status is ready (16 retries left).
FAILED - RETRYING: [localhost]: Wait until localstack status is ready (15 retries left).
FAILED - RETRYING: [localhost]: Wait until localstack status is ready (14 retries left).
FAILED - RETRYING: [localhost]: Wait until localstack status is ready (13 retries left).
FAILED - RETRYING: [localhost]: Wait until localstack status is ready (12 retries left).
FAILED - RETRYING: [localhost]: Wait until localstack status is ready (11 retries left).
FAILED - RETRYING: [localhost]: Wait until localstack status is ready (10 retries left).
FAILED - RETRYING: [localhost]: Wait until localstack status is ready (9 retries left).
FAILED - RETRYING: [localhost]: Wait until localstack status is ready (8 retries left).
FAILED - RETRYING: [localhost]: Wait until localstack status is ready (7 retries left).
FAILED - RETRYING: [localhost]: Wait until localstack status is ready (6 retries left).
FAILED - RETRYING: [localhost]: Wait until localstack status is ready (5 retries left).
FAILED - RETRYING: [localhost]: Wait until localstack status is ready (4 retries left).
FAILED - RETRYING: [localhost]: Wait until localstack status is ready (3 retries left).
FAILED - RETRYING: [localhost]: Wait until localstack status is ready (2 retries left).
FAILED - RETRYING: [localhost]: Wait until localstack status is ready (1 retries left).
fatal: [localhost]: FAILED! => {"attempts": 18, "changed": false, "content": "", "elapsed": 0, "msg": "Status code was -1 and not [200]: Request failed: <urlopen error [Errno 111] Connection refused>", "redirected": false, "status": -1, "url": "http://localhost:4566/"}
I just kicked off https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-12252/3/
There was a problem hiding this comment.
Same localstack failure at https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-12252/3/console
Third time's the charm? 😅 I kicked off https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-12252/4/
There was a problem hiding this comment.
https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-12252/4/ failed too. Same error. I started a thread in Slack: https://iqss.slack.com/archives/C010LA04BCG/p1774458315488609
There was a problem hiding this comment.
No problems on my laptop:
docker logs dev_localstack
LocalStack version: 4.2.0
LocalStack build date: 2025-02-27
LocalStack build git hash: 2144203e0
2026-03-25T17:24:02.119 WARN --- [ MainThread] localstack.deprecations : HOSTNAME_EXTERNAL is deprecated (since 2.0.0) and will be removed in upcoming releases of LocalStack! This configuration will be migrated to LOCALSTACK_HOST
2026-03-25T17:24:06.981 INFO --- [et.reactor-0] localstack.request.aws : AWS s3.CreateBucket => 200
make_bucket: mybucket
Ready.
🤷
There was a problem hiding this comment.
Since it's working on my laptop, I created an issue on the ansible side:
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
CI is failing but seems unrelated to this PR. Details at #12252 (comment) and in Slack.
I tested this PR locally and this is definitely better than what we shipped in 6.10. I'm not sure if I'm hitting all use cases, but I'm approving this, at least.
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
github-project-automation
bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
4 participants
What this PR does / why we need it: Method signature changed causing xhtml to not find the method. See issue for details
Which issue(s) this PR closes:#12251
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: Included
Additional documentation: