Fixed Anonymous guestbook file download via persistentId#12363
Fixed Anonymous guestbook file download via persistentId#12363stevenwinship wants to merge 2 commits intodevelopfrom
Conversation
|
coverage: 24.964% (+0.002%) from 24.962% — 12245-anon-guestbook-download-via-persistentid into develop |
This comment has been minimized.
This comment has been minimized.
stevenwinship
force-pushed
the
12245-anon-guestbook-download-via-persistentid
branch
from
04e5ba0 to
78793ff
Compare
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
stevenwinship
moved this from In Progress 💻
to Ready for Review ⏩
in IQSS Dataverse Project
landreev
left a comment
landreev
left a comment
There was a problem hiding this comment.
One quick request:
Could you please fix all the misspelled signature-secret in config.rst as well in the same pr.
| requestSpecification.body(body); | ||
| } | ||
| String getString = "/api/access/dataset/:persistentId?persistentId=" + persistentId; | ||
| String getString = "/api/access/datafile/:persistentId?persistentId=" + persistentId; |
There was a problem hiding this comment.
From a quick glance, hard-coding "datafile" here may not be ideal.
This UtilIT method is also called from FilesIT.testDownloadFileWithGuestbookResponseUsingBearerToken() method, where the pid appears to be of a dataset and in the context of /api/access/dataset.
I see that the test is @Disabled, but I'm assuming you want it to work on demand.
| downloadResponse = UtilIT.downloadFilesUrlWithGuestbookResponse(persistentId, apiToken, guestbookResponse); | ||
| // Get Signed Download Url for guest with guestbook response using file's persistentId | ||
| // POST /api/access/dataset/:persistentId?persistentId= | ||
| downloadResponse = UtilIT.downloadFilesUrlWithGuestbookResponse(filePersistentId, null, guestbookResponseForGuest); |
There was a problem hiding this comment.
Also, this looks like this test of /api/access/datafile/:persistentId is being added at the expense of dropping testing of /api/access/dataset/:persistentId that used to be here.
We probably want to test both, no?
3 participants
What this PR does / why we need it:Guest downloads using persistentId were not working When guestbook responses were given.
Which issue(s) this PR closes:#12245
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: Included
Additional documentation: