12367 GitHub actions workflow for jenkins redundancy#12368
Open
srmanda-cs wants to merge 11 commits intoIQSS:developfrom
Open
12367 GitHub actions workflow for jenkins redundancy#12368srmanda-cs wants to merge 11 commits intoIQSS:developfrom
srmanda-cs wants to merge 11 commits intoIQSS:developfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new GitHub Actions workflow intended to run the same API/integration test suite as Jenkins, but against a Dataverse stack started via the Maven container tooling, improving CI redundancy and visibility of failures.
Changes:
- Added
.github/workflows/container_integration_tests.ymlto build/start the container stack, runtests/integration-tests.txt, and publish test artifacts/results. - Updated
SearchITto search for the dataset via theid:dataset_<id>query pattern. - Disabled
testRetrieveMyDataCollectionsinDataRetrieverApiIT.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
src/test/java/edu/harvard/iq/dataverse/api/SearchIT.java |
Adjusts dataset search query to use id:dataset_<id> format. |
src/test/java/edu/harvard/iq/dataverse/api/DataRetrieverApiIT.java |
Disables a failing/unstable test method. |
.github/workflows/container_integration_tests.yml |
Introduces a new container-based integration test workflow, including reporting and artifacts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+227
to
+231
| # The pom.xml automatically merged the files and put them here: | ||
| mvn coveralls:report \ | ||
| -P all-unit-tests \ | ||
| -DrepoToken=$COVERALLS_REPO_TOKEN \ | ||
| -DjacocoReports=target/site/jacoco-merged-test-coverage-report/jacoco.xml |
Author
There was a problem hiding this comment.
This is probably wrong, but let me verify just in case.
Author
There was a problem hiding this comment.
This is right, JaCoCo reporting is failing
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Updated concurrency group name to include branch reference and removed .txt files from paths-ignore.
Removed .txt files from paths-ignore in workflow.
Temporarily disable unreliable integration test for retrieving data collections.
Removed force_run input from workflow dispatch.
Replace curl command with docker cp for SUSHI config file.
Replaced local file copy with curl command to fetch SUSHI config.
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add a GitHub Actions Workflow that replicates the exact same tests that Jenkins run with the same configurations, but with containers instead
Which issue(s) this PR closes:
Special notes for your reviewer:
All your suggestions and criticism are deeply welcome, and since it is a major workflow I'm willing to work on it again and again until it meets Dataverse's needs accurately and addresses any concerns the team has. There will probably be a lot, since this is a prototype workflow that I quickly hacked together in a few weeks.
Suggestions on how to test this:
Clicking run workflow should do it.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
N/A
Is there a release notes update needed for this change?:
N/A
Additional documentation:
Depends on where and how you would want me to document it.