Skip to content

Fixes to counter-weekly and updateCitationsForDataset API#12397

Merged
stevenwinship merged 1 commit into
developfrom
12384-fixes-for-mdc-datasetexternalcitations
May 20, 2026
Merged

Fixes to counter-weekly and updateCitationsForDataset API#12397
stevenwinship merged 1 commit into
developfrom
12384-fixes-for-mdc-datasetexternalcitations

Conversation

@stevenwinship
Copy link
Copy Markdown
Contributor

What this PR does / why we need it: Logging was only displaying :persistentId for the dataset id instead of the actual db id

Which issue(s) this PR closes:#12384

Special notes for your reviewer: counter-weekly.sh exists in 2 places. I copied the script to the doc area instead of just removing one and modifying the doc.

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@github-actions github-actions Bot added FY26 Sprint 22 FY26 Sprint 22 (2026-04-22 - 2026-05-06) FY26 Sprint 23 FY26 Sprint 23 (2026-05-06 - 2026-05-20) Size: 80 A percentage of a sprint. 56 hours. labels May 18, 2026
@stevenwinship stevenwinship self-assigned this May 18, 2026
@stevenwinship stevenwinship moved this to In Progress 💻 in IQSS Dataverse Project May 18, 2026
@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 24.953% (-0.001%) from 24.954% — 12384-fixes-for-mdc-datasetexternalcitations into develop

@github-actions
Copy link
Copy Markdown

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:12384-fixes-for-mdc-datasetexternalcitations
ghcr.io/gdcc/configbaker:12384-fixes-for-mdc-datasetexternalcitations

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@stevenwinship stevenwinship moved this from In Progress 💻 to Ready for Review ⏩ in IQSS Dataverse Project May 19, 2026
@stevenwinship stevenwinship removed their assignment May 19, 2026
Copy link
Copy Markdown
Contributor

@rtreacy rtreacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update works and logging is improved

@github-project-automation github-project-automation Bot moved this from Ready for Review ⏩ to Ready for QA ⏩ in IQSS Dataverse Project May 19, 2026
@stevenwinship stevenwinship merged commit d0b449a into develop May 20, 2026
23 of 25 checks passed
@github-project-automation github-project-automation Bot moved this from Ready for QA ⏩ to Merged 🚀 in IQSS Dataverse Project May 20, 2026
@stevenwinship stevenwinship deleted the 12384-fixes-for-mdc-datasetexternalcitations branch May 20, 2026 14:03
@pdurbin pdurbin moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project May 20, 2026
@pdurbin pdurbin added this to the 6.11 milestone May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY26 Sprint 22 FY26 Sprint 22 (2026-04-22 - 2026-05-06) FY26 Sprint 23 FY26 Sprint 23 (2026-05-06 - 2026-05-20) Size: 80 A percentage of a sprint. 56 hours.

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

Fixes for APIs related to Make Data Count when trying to update datasetexternalcitations

4 participants