Directory names conflicting with file names#12407
Open
jo-pol wants to merge 2 commits into
Open
Conversation
- EditDatafilesPage: message shows all conflicting files, not just the first - a file with a directory conflicting with an existing full path is rejected - files with a full path that conflicts with an existing directory will get a sequence number added - additional unit test - manual test script - scripts to detect (latest version of) datasets with conflicting directory paths Note that directory does not just mean directoryLabel, but also the parents in the directoryLabel
jo-pol
changed the title
pdurbin
moved this from Ready for Triage
to Ready for Review ⏩
in IQSS Dataverse Project
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| r = requests.post(url, headers=headers, json=json_content, verify=False) | ||
|
|
||
| print(r.status_code) | ||
| print(r.text) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Downloads result in unzip problems for datasets with full file-paths duplicating directories. Note that directory does not just mean the directoryLabel, but also the parents in the directoryLabel.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
See the changed
dataset-management.rstfile, the other changed rst file had a typo.Is there a release notes update needed for this change?:
Existing datasets with the new type of duplicate names should be identified, see:
scripts/issues/dirs-duplicating-files/find_duplicates.pyThe reported datasets should be fixed manually, best before deploying this fix. Depending on your preferences and the size of your database you might want a variation of the scripts.Additional documentation:
Screenshots for the results of test-apis.py before and after deploy. Before depoly we see conflicts on foo and foo/bar), after deploy some request return 400-bad-request.
