Skip to content

#3505 - Fix permissions gathering for Dataset Page#3512

Merged
kcondon merged 1 commit intodevelopfrom
3505-file-restriction-display
Dec 8, 2016
Merged

#3505 - Fix permissions gathering for Dataset Page#3512
kcondon merged 1 commit intodevelopfrom
3505-file-restriction-display

Conversation

@sekmiller
Copy link
Copy Markdown
Contributor

@sekmiller sekmiller commented Dec 6, 2016

RFI Checklist

Before submitting the pull request, fill out sections (1.) Related Issues and (2.) Pull Request Checklist.

1. Related Issues

List and link to the issues in this Pull Request.

  • [3505 + Restricting a second file after granting access to first shows open lock and removes req access button on second]

2. Pull Request Checklist

  • Functionality completed as described in FRD
  • [NA] Dependencies, risks, assumptions in FRD addressed
  • [NA] Unit tests completed
  • [NA] Deployment requirements identified (e.g., SQL scripts, indexing)
  • [NA] Documentation completed
  • All code checkins completed

3. Review Checklist

After the pull request has been submitted, fill out this section.

  • Code review completed or waived
  • Testing requirements completed
  • Usability testing completed or waived
  • Support testing completed or waived
  • Merged with develop branch and resolved conflicts

Connects to #3505.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.0009%) to 8.71% when pulling 7c17b1b on 3505-file-restriction-display into 75a4146 on develop.

@sekmiller
Copy link
Copy Markdown
Contributor Author

Code changes reviewed by @raprasad. thanks!

@sekmiller sekmiller added this to the 4.6 - File Replace milestone Dec 7, 2016
@kcondon kcondon merged commit 6c6f900 into develop Dec 8, 2016
@kcondon kcondon deleted the 3505-file-restriction-display branch December 8, 2016 17:09
@kcondon kcondon self-assigned this Dec 8, 2016
@kcondon kcondon removed the Status: QA label Dec 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants