Skip to content

Comments

3852 query 600#3864

Merged
kcondon merged 15 commits intodevelopfrom
3852-query-600
May 31, 2017
Merged

3852 query 600#3864
kcondon merged 15 commits intodevelopfrom
3852-query-600

Conversation

@landreev
Copy link
Contributor

@landreev landreev commented May 30, 2017

New Contributors

Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!

Related Issues

Pull Request Checklist

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 10.02% when pulling f265c68 on 3852-query-600 into cb0e38f on develop.

@raprasad
Copy link
Contributor

  • Code review looks fine.
  • I see some extra lines that I can take out--they were part of my interim fix and not used by the last updates
    • However, I can defer on this so as not to hold the process back.

…iceBean

It’s done in the SearchIncludeFragment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 10.022% when pulling ad544e6 on 3852-query-600 into cb0e38f on develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 10.023% when pulling a74895d on 3852-query-600 into cb0e38f on develop.

descriptions/redirect urls for harvested datasets;
persisting selected thumbnails;
some cleanup.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 10.022% when pulling f5cb288 on 3852-query-600 into cb0e38f on develop.

@raprasad
Copy link
Contributor

connects to #3858

landreev added 2 commits May 31, 2017 13:19
fixes the optimized lookup of tabular data files;
proper thumbnail generation for worldmap files;
isolates the optimized thumbnail handling in its own ViewScope wrapper;
makes the dataset page call the wrapper to obtain the dataset-level logo for the top of the page, when in optimized mode;
properly implements the persistence of auto-selected thumbnails.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 10.039% when pulling 720dca3 on 3852-query-600 into cb0e38f on develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 10.039% when pulling 4865406 on 3852-query-600 into d824580 on develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 10.039% when pulling f6b666b on 3852-query-600 into 20d85b3 on develop.

@kcondon kcondon merged commit 0c4ca84 into develop May 31, 2017
@kcondon kcondon deleted the 3852-query-600 branch May 31, 2017 21:26
@pdurbin pdurbin added this to the 4.6.2 - Tabular Mapping milestone Jun 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants