Conversation
This commit and the subsequent ones are pretty comment heavy, I'll clean them up closer to completion
Turns out the format checking functionality I wanted to use is too tied in with DownloadInstance which our zip creator does not use. I'm going to approach the check via different means
Also improved tests
Still fairly rough, need render logic to switch between the two download buttons
landreev
approved these changes
Aug 22, 2018
Contributor
landreev
left a comment
landreev
left a comment
There was a problem hiding this comment.
Reviewed AND tested. Looks good!
Appreciate the extra cleanup of the code that generates these zipped up bundles; removing the dead code, renaming some methods to better reflect what they do, etc.
|
|
||
| private Boolean hasRsyncScript = false; | ||
|
|
||
| private Boolean hasTabular = false; |
Contributor
There was a problem hiding this comment.
shouldn't every Boolean in this pr be boolean?
resolved conflicts; (#4000)
…ginal, when using batch download w/ single file boxes checked. (#4000)
…estbook saving and download starting code. (#4000)
More bugfixes, cleanup, refactoring, etc. (#4000)
…picking at this point. (#4000)
… requested. still confused as to why we invested the effort into creating that disabling-downloads-while-dataset-is-locked logic in the first place (??) - so left some TODO comments in the code... (#4000)
pdurbin
added this to the
4.9.3 - Optional File PIDs, Initial Internationalization Work milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Creating this PR in @matthew-a-dunlap's stead)
Related Issues
Pull Request Checklist