Skip to content

#5981 check for empty value array#5982

Merged
kcondon merged 1 commit intodevelopfrom
5981-index-fails-for-empty-date-fields
Jul 10, 2019
Merged

#5981 check for empty value array#5982
kcondon merged 1 commit intodevelopfrom
5981-index-fails-for-empty-date-fields

Conversation

@sekmiller
Copy link
Copy Markdown
Contributor

@sekmiller sekmiller commented Jun 27, 2019

New Contributors

Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!

Related Issues

Pull Request Checklist

  • Unit [tests][x] completed
  • Integration [tests][x]: completed
  • Deployment requirements: None
  • Documentation NA
  • Merged latest from "develop" [branch][x] and resolved conflicts

Copy link
Copy Markdown
Contributor

@mheppler mheppler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Sorry, did not see this was already approved and moved to QA.

@kcondon kcondon self-assigned this Jul 9, 2019
@djbrooke djbrooke added this to the 4.15.1 milestone Jul 10, 2019
@kcondon kcondon merged commit 1b073e3 into develop Jul 10, 2019
@kcondon kcondon deleted the 5981-index-fails-for-empty-date-fields branch July 10, 2019 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Indexing fails for Empty Date Field

5 participants