use correct duration for dataset publication locks#7833
Merged
Conversation
scolapasta
approved these changes
Apr 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In the test suite, when we added sleeps for locks we specified a duration for ingest (3 seconds) and a duration for publish (15 seconds). Only the ingest duration was used. This pull request switches the publish operations to use the duration for publish. I only noticed this because when testing the creation of a dataset with 200 versions, the number of seconds to publish quickly exceeded the lower ingest limit.
Which issue(s) this PR closes:
Closes # (none)
Special notes for your reviewer:
None. Just test code.
Suggestions on how to test this:
Let the test suite run on Jenkins.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
No.
Additional documentation:
None.