Skip to content

Do not count downloads for thumbnails when redirecting to s3#7926

Merged
kcondon merged 1 commit intodevelopfrom
7294-s3-redirect-regression
Jun 30, 2021
Merged

Do not count downloads for thumbnails when redirecting to s3#7926
kcondon merged 1 commit intodevelopfrom
7294-s3-redirect-regression

Conversation

@landreev
Copy link
Copy Markdown
Contributor

@landreev landreev commented Jun 7, 2021

What this PR does / why we need it:

A one line fix for a regression introduced in 5.5

Which issue(s) this PR closes:

Closes #7924

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

…imilarly to how these downloads are treated when done internally, without redirecting to the remote bucket, in line 457). #7924
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 19.324% when pulling 9acea6b on 7294-s3-redirect-regression into b61b572 on develop.

@kcondon kcondon self-assigned this Jun 30, 2021
@kcondon kcondon merged commit 5fab3f1 into develop Jun 30, 2021
@kcondon kcondon deleted the 7294-s3-redirect-regression branch June 30, 2021 16:22
@djbrooke djbrooke added this to the 5.6 milestone Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression (5.5): with S3 redirects enabled, getting a thumbnail via API increments download count

5 participants