Merged
Conversation
scolapasta
reviewed
Jul 26, 2021
|
|
||
| private boolean backingShowDeleted = true; | ||
|
|
||
| public String showDeletedCheckboxChange() { |
Contributor
There was a problem hiding this comment.
@sekmiller Only small comment, does this need to return "" or can it just be void?
Contributor
Author
There was a problem hiding this comment.
you're right. thanks. I made the change.
scolapasta
approved these changes
Jul 26, 2021
Contributor
|
Tested on reported dataset: old: 3m45s new: 1m17s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Improves performance of the Manage File Permissions page. It is timing out for a dataset with many files.
Which issue(s) this PR closes:
Closes #
IQSS/dataverse.harvard.edu#118
Special notes for your reviewer:
Most gains are achieved by adding a method for the onchange event of the Show Deleted Files button. Prior to this the init maps was being called three times on page load. Also stopped checking for "deleted" if the file was not restricted.
Suggestions on how to test this:
Try a dataset with a lot of restricted files and see that the page loads faster without losing any functionality.
Does this PR introduce a user interface change? If mockups are available, please link/include them here: No
Is there a release notes update needed for this change?: No
Additional documentation:None