IQSS/8032 Add optional flag to trigger update of PID at provider during migrate#8034
Merged
kcondon merged 6 commits intoIQSS:developfrom Aug 3, 2021
Conversation
qqmyers
changed the title
landreev
approved these changes
Jul 29, 2021
Contributor
landreev
left a comment
landreev
left a comment
There was a problem hiding this comment.
Agree, that this is safer, than to do the update automatically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Disables updating the PID at the provider during the /api/datasets/<id>/actions/:releasemigrated call unless ?updatepidatprovider=true is added to the URL.
Which issue(s) this PR closes:
Closes #8032
Special notes for your reviewer: This is probably safer than the just merged API call which will try to change the PID at the provider by default.
Suggestions on how to test this: Should be able to repeat the migrate tests and verify that the DOI doesn't redirect without the param and does when it is true.
Does this PR introduce a user interface change? If mockups are available, please link/include them here: no
Is there a release notes update needed for this change?: no
Additional documentation: added notes about the new param