Merged
Conversation
landreev
approved these changes
Jul 29, 2021
Contributor
landreev
left a comment
landreev
left a comment
There was a problem hiding this comment.
Looks straightforward, approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Deleting a dataset version from the dataset page does not remove the physical files that had been added to that version. Because of this there are files in storage that were never part of a published or current draft dataset version.
Which issue(s) this PR closes:
Closes #7790 Deleting a draft of a published dataset does not remove files added in that draft
Special notes for your reviewer: Not much since the code had already been written for the delete draft version via the api/
Suggestions on how to test this: Add files to a draft version. See that they are saved to the file system. Delete that draft and verify they have been removed while those files from previous published versions remain.
Does this PR introduce a user interface change? If mockups are available, please link/include them here: No
Is there a release notes update needed for this change?:
No. unless we want to note that existing files created for deleted versions prior to this change will not be removed by this change. There's a separate issue for that clean up.
Additional documentation: None