Conversation
Tom-Willemsen
force-pushed
the
initial
branch
21 times, most recently
from
bc7629a to
ec42d56
Compare
rerpha
left a comment
rerpha
left a comment
There was a problem hiding this comment.
looks good and works well - just some minor comments
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| matrix: | ||
| os: [ "ubuntu-latest", "windows-latest" ] |
There was a problem hiding this comment.
is there any point running the tests on linux if we wrap wincred?
There was a problem hiding this comment.
and is there benefit to running these as separate jobs rather than steps within a job?
There was a problem hiding this comment.
ick json is usable on linux, although whether that's a useful enough thing by itself I'm unsure? Happy to just go to windows-only depending what you prefer?
(originally I also had an ick ssh, but that's superceded by just using key-based auth)...
There was a problem hiding this comment.
up to you really - maybe not needed
There was a problem hiding this comment.
I'll leave as-is for the moment and we can revisit if we want / next time (if ever) we end up touching this tool.
2 participants
See also ISISComputingGroup/ibex_utils#277 if you don't have rust locally