-
Notifications
You must be signed in to change notification settings - Fork 0
Initial #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Initial #1
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
d51aae1
Framework
Tom-Willemsen e14459e
gitignore
Tom-Willemsen 61348de
Add kdbx support
Tom-Willemsen 8aac7d7
add functionality
Tom-Willemsen 86c770f
doc
Tom-Willemsen ff6069d
Remove ssh
Tom-Willemsen 6a95fb7
Use winapi
Tom-Willemsen 00bef3b
add functionality
Tom-Willemsen 0e362ab
code
Tom-Willemsen 965f89d
gha
Tom-Willemsen d704a45
Add more unit tests
Tom-Willemsen c1df1bc
Merge branch 'main' into initial
Tom-Willemsen 2e4c4ac
Review comments
Tom-Willemsen 03266be
Merge branch 'initial' of https://github.com/Tom-Willemsen/ick into i…
Tom-Willemsen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| version: 2 | ||
| updates: | ||
| - package-ecosystem: "cargo" | ||
| directory: "/" | ||
| schedule: | ||
| interval: "weekly" | ||
| - package-ecosystem: "github-actions" | ||
| directory: "/" | ||
| schedule: | ||
| interval: "weekly" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| name: Nightly build | ||
| on: | ||
| schedule: | ||
| - cron: "51 3 * * *" | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| nightly-build: | ||
| uses: ./.github/workflows/build.yml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,103 @@ | ||
| name: Build | ||
| on: [push, workflow_call] | ||
|
|
||
| permissions: | ||
| contents: write | ||
|
|
||
| jobs: | ||
| lint: | ||
| runs-on: "windows-latest" | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: install stable rust | ||
| run: rustup install stable | ||
| - uses: Swatinem/rust-cache@v2 | ||
| - name: Format check | ||
| run: cargo fmt --check | ||
| - name: Clippy | ||
| run: cargo clippy -- --deny warnings | ||
| docs: | ||
| runs-on: "windows-latest" | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: install stable rust | ||
| run: rustup install stable | ||
| - uses: Swatinem/rust-cache@v2 | ||
| - name: Build docs | ||
| run: cargo doc --no-deps | ||
| - name: Generate index.html | ||
| shell: cmd | ||
| # u wot? | ||
| run: | | ||
| echo|set /p="<meta http-equiv="refresh" content="0; url=ick/">" > target/doc/index.html | ||
| exit /B 0 | ||
| - name: Upload artifacts (docs) | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: docs | ||
| path: | | ||
| target/doc | ||
| if-no-files-found: error | ||
| retention-days: 1 | ||
| - name: Deploy docs | ||
| uses: peaceiris/actions-gh-pages@v3 | ||
| if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/initial' }} | ||
| with: | ||
| publish_branch: gh-pages | ||
| github_token: ${{ secrets.GITHUB_TOKEN }} | ||
| publish_dir: target/doc | ||
| force_orphan: true | ||
| tests: | ||
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| matrix: | ||
| os: [ "ubuntu-latest", "windows-latest" ] | ||
| fail-fast: false | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: install stable rust | ||
| run: rustup install stable | ||
| - uses: Swatinem/rust-cache@v2 | ||
| with: | ||
| key: ${{ matrix.os }} | ||
| - name: Unit tests | ||
| run: cargo test | ||
| - name: Unit tests (release mode) | ||
| run: cargo test --release | ||
| - name: Build (debug) | ||
| run: cargo build | ||
| - name: Build (release) | ||
| run: cargo build --release | ||
| - name: Upload artifacts (debug) | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: ${{ format('debug-{0}', matrix.os) }} | ||
| path: | | ||
| target/debug/ick | ||
| target/debug/ick.exe | ||
| target/debug/ick.pdb | ||
| if-no-files-found: error | ||
| retention-days: 1 | ||
| - name: Upload artifacts (release) | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: ${{ format('release-{0}', matrix.os) }} | ||
| path: | | ||
| target/release/ick | ||
| target/release/ick.exe | ||
| target/release/ick.pdb | ||
| if-no-files-found: error | ||
| retention-days: 1 | ||
| results: | ||
| if: ${{ always() }} | ||
| runs-on: ubuntu-latest | ||
| name: Final Results | ||
| needs: [tests, lint, docs] | ||
| steps: | ||
| - run: exit 1 | ||
| # see https://stackoverflow.com/a/67532120/4907315 | ||
| if: >- | ||
| ${{ | ||
| contains(needs.*.result, 'failure') | ||
| || contains(needs.*.result, 'cancelled') | ||
| }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # Generated by Cargo | ||
| # will have compiled files and executables | ||
| debug | ||
| target | ||
|
|
||
| # These are backup files generated by rustfmt | ||
| **/*.rs.bk | ||
|
|
||
| # MSVC Windows builds of rustc generate these, which store debugging information | ||
| *.pdb | ||
|
|
||
| # Generated by cargo mutants | ||
| # Contains mutation testing data | ||
| **/mutants.out*/ | ||
|
|
||
| # RustRover | ||
| .idea/ |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any point running the tests on linux if we wrap wincred?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and is there benefit to running these as separate jobs rather than steps within a job?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ick jsonis usable on linux, although whether that's a useful enough thing by itself I'm unsure? Happy to just go to windows-only depending what you prefer?(originally I also had an
ick ssh, but that's superceded by just using key-based auth)...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
up to you really - maybe not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll leave as-is for the moment and we can revisit if we want / next time (if ever) we end up touching this tool.