IntegrationTest: catch ResolverError for URL-based downstreams#80
Merged
IntegrationTest: catch ResolverError for URL-based downstreams#80
Conversation
The URL branch (unregistered / private packages specified by
`https://...` or `git@...`) previously ran `Pkg.add(url=pkg)`,
`Pkg.develop(".")`, and `Pkg.update()` without any error handling, so a
breaking change in the PR that the downstream's compat didn't allow
blew up the integration test job instead of being reported as an
intentional SemVer-breaking change.
Move the existing `try/catch Pkg.Resolve.ResolverError` wrapper up to
cover the full `if/else`, so both the URL branch and the registered-
package branch share the same "not compatible with this release" exit.
Surfaced by ITensor/ITensorNetworks.jl#327 where the Tennis.jl
downstream (passed as a URL) failed with `ResolverError` after the PR
bumped ITensorNetworks to 0.16.0.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
try/catch Pkg.Resolve.ResolverErrorwrapper was only around the registered-package branch ofIntegrationTest.yml. URL-based downstreams (unregistered / private packages specified ashttps://...orgit@...) ranPkg.add(url=pkg)/Pkg.develop(".")/Pkg.update()with no error handling, so a breaking change in the PR that the downstream's compat didn't allow failed the job instead of being reported as an intentional SemVer-breaking change.This PR hoists the existing
try/catchup to cover the fullif/else, so both branches share one resolver-error exit (the "not compatible with this release — no problem" path). No other behavior changes.Surfaced by ITensor/ITensorNetworks.jl#327, where the Tennis.jl downstream (passed as a URL) failed with
ResolverErrorafter the PR bumped ITensorNetworks to 0.16.0.