Conversation
Delete the ITensorNetworksEinExprsExt extension and its tests. The `alg = "einexpr"` contraction sequence optimizer is no longer supported; use `alg = "optimal"`, `"greedy"`, `"tree_sa"`, `"sa_bipartite"`, or `"kahypar_bipartite"` via OMEinsumContractionOrders instead. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Removing the EinExprs extension drops the `alg = "einexpr"` contraction sequence algorithm, so this is a breaking change. Bump the root package to 0.16.0 and update the pinned version in test/, docs/, and examples/ Project.toml files to match. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mtfishman
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #327 +/- ##
==========================================
- Coverage 71.45% 71.25% -0.20%
==========================================
Files 81 80 -1
Lines 4029 4001 -28
==========================================
- Hits 2879 2851 -28
Misses 1150 1150
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mtfishman
changed the title
mtfishman
added a commit
to ITensor/ITensorActions
that referenced
this pull request
Apr 23, 2026
## Summary
The `try/catch Pkg.Resolve.ResolverError` wrapper was only around the
registered-package branch of `IntegrationTest.yml`. URL-based
downstreams (unregistered / private packages specified as `https://...`
or `git@...`) ran `Pkg.add(url=pkg)` / `Pkg.develop(".")` /
`Pkg.update()` with no error handling, so a breaking change in the PR
that the downstream's compat didn't allow failed the job instead of
being reported as an intentional SemVer-breaking change.
This PR hoists the existing `try/catch` up to cover the full `if/else`,
so both branches share one resolver-error exit (the "not compatible with
this release — no problem" path). No other behavior changes.
Surfaced by
[ITensor/ITensorNetworks.jl#327](ITensor/ITensorNetworks.jl#327),
where the Tennis.jl downstream (passed as a URL) failed with
`ResolverError` after the PR bumped ITensorNetworks to 0.16.0.
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
Author
|
Closing and reopening to trigger a fresh IntegrationTest run that picks up ITensor/ITensorActions#80 (URL-branch ResolverError catch) from main. The previous |
mtfishman
added a commit
that referenced
this pull request
Apr 26, 2026
`DataStructures` was narrowed to `"0.18"` in #328 because the `EinExprs` weakdep pinned it that way. The `EinExprs` dependency was removed in #327, but the narrowed `DataStructures` compat was never reverted (and `DataStructures` itself is no longer `using`'d anywhere in `src/`, `ext/`, or `test/`). Drop the entry entirely from `[deps]` and `[compat]`. This also unblocks `OrdinaryDiffEqTsit5 = "1.1, 2"` resolution: the v2 chain pulls in `OrdinaryDiffEqCore` 4, which requires `DataStructures` 1.x-3.x and was previously incompatible with the 0.18 pin. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mtfishman
added a commit
that referenced
this pull request
Apr 26, 2026
`DataStructures` was narrowed to `"0.18"` in #328 because the `EinExprs` weakdep pinned it that way. The `EinExprs` dependency was removed in #327, but the narrowed `DataStructures` compat was never reverted (and `DataStructures` itself is no longer `using`'d anywhere in `src/`, `ext/`, or `test/`). Drop the entry entirely from `[deps]` and `[compat]`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
alg = "einexpr"contraction sequence optimizer. Downstream users should switch to one of"optimal","greedy","tree_sa","sa_bipartite", or"kahypar_bipartite"(all still dispatched through the OMEinsumContractionOrders extension).ITensorNetworksEinExprsExtweak-dep extension and dropsEinExprsfrom both the root andtest/Project.toml.alg = "einexpr"cases (and the commented-out KaHyPar/einexpr block) fromtest/test_contraction_sequence.jl.0.16.0(minor bump for a pre-1.0 breaking change) and updates pinnedITensorNetworkscompat intest/,docs/, andexamples/Project.toml accordingly.