[IULRDC-216] add rack attack and robots.txt editing - #74
Merged
Conversation
rdlebeau
requested changes
Jun 30, 2026
rdlebeau
left a comment
rdlebeau
left a comment
Contributor
There was a problem hiding this comment.
This PR needs unit tests for robots_controller.rb and rack_attacks_controller.rb.
| clients based on the criteria set in the <a href="https://yaml.org/">YAML</a> formatted file below. | ||
| Changes may take up to the Config TTL to become active. | ||
| Listed safe paths/ips/agents are not subject to blocking or throttling. Each entry in the throttle section defines | ||
| a discriminator that can thought of as a bucket that matching requests fill up. The throttle limit/period |
Contributor
There was a problem hiding this comment.
Instead of "discriminator that can thought of as a bucket", perhaps we should say "discriminator that can be thought of as a bucket" ?
Contributor
Author
There was a problem hiding this comment.
@rdlebeau see 5 new additional commits for spec coverage, typo fix
rdlebeau
approved these changes
Jul 2, 2026
rdlebeau
left a comment
rdlebeau
left a comment
Contributor
There was a problem hiding this comment.
I approve these changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As in essi, datacore