Skip to content

Update favicon#43

Merged
VictorLeach96 merged 1 commit into
mainfrom
feat/update-favicon
Apr 20, 2026
Merged

Update favicon#43
VictorLeach96 merged 1 commit into
mainfrom
feat/update-favicon

Conversation

@VictorLeach96

@VictorLeach96 VictorLeach96 commented Apr 20, 2026

Copy link
Copy Markdown
Member

Note

Low Risk
Low risk: this only replaces the favicon.svg asset and does not touch runtime logic or data handling.

Overview
Updates the app/site favicon by replacing fern/assets/favicon.svg with a new SVG (different dimensions/viewBox and white-filled paths), removing the previous colored icon and adding a properly newline-terminated file.

Reviewed by Cursor Bugbot for commit f5f1a9b. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f5f1a9b. Configure here.

Comment thread fern/assets/favicon.svg
<path fill-rule="evenodd" clip-rule="evenodd" d="M187.356 62.363C187.356 50.5905 173.994 42.7582 163.78 48.6447L91.7886 90.3039C87.6067 92.9588 84.8172 97.9822 84.625 102.4V220.123C84.625 228.789 93.9181 234.841 102.476 230.447L141.341 207.815C146.902 204.209 148.898 199.359 148.898 194.681C148.898 194.681 148.95 187.576 148.898 185.39C148.438 165.22 152.352 154.478 168.979 144.859C171.795 143.23 176.028 140.774 179.229 138.929C182.432 137.083 187.356 132.7 187.356 124.314V62.363Z" fill="white"/>
<path fill-rule="evenodd" clip-rule="evenodd" d="M64.3364 103.468C64.3364 97.2289 60.4591 92.3616 56.7398 90.2095C56.6984 90.1854 56.6959 90.1875 18.3283 67.9915C8.94268 62.5601 0 70.581 0 79.6062V167.644C0 173.891 4.03564 178.799 7.11227 180.579C8.81852 181.569 6.74474 180.368 46.4294 203.325C53.6534 207.504 64.3364 202.265 64.3364 191.654C64.3364 101.654 64.3364 105.282 64.3364 103.468Z" fill="white"/>
<path fill-rule="evenodd" clip-rule="evenodd" d="M93.8886 2.42073C89.0084 -0.513949 83.2204 -0.893243 78.2599 1.90528L31.66 29.0784C24.0635 33.4744 20.9406 46.0811 29.3599 50.951C51.9647 64.0295 60.2672 68.8361 65.8926 72.0896C71.0038 75.0461 77.3812 75.2115 82.4925 72.2549C97.5352 63.5528 67.3796 80.8326 129.368 44.9721C137.093 40.501 138.794 28.4048 130.36 23.525C108.552 10.9062 99.6281 5.87327 93.8886 2.42073Z" fill="white"/>
</svg>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

White favicon invisible on light backgrounds

Medium Severity

The new favicon SVG has all three <path> elements using fill="white" on a transparent background (fill="none" on the root <svg>). Favicons are rendered in browser chrome (tabs, bookmarks bar, history) which typically has a light or white background in light mode. This makes the favicon completely invisible for users with light-themed browsers, effectively breaking the site's branding for a significant portion of users.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit f5f1a9b. Configure here.

Comment thread fern/assets/favicon.svg
@@ -1 +1,5 @@
<svg clip-rule="evenodd" fill-rule="evenodd" stroke-linejoin="round" stroke-miterlimit="2" viewBox="0 0 100 100" xmlns="http://www.w3.org/2000/svg"><path d="m0 0h100v100h-100z" fill="none"/><path d="m88.351 28.043c0-4.842-5.354-8.071-9.55-5.65l-29.577 17.134c-1.718 1.092-2.864 3.158-2.943 4.975v48.418c0 3.565 3.818 6.054 7.334 4.247l15.967-9.309c2.285-1.483 3.105-3.478 3.105-5.402 0 0 .021-2.922 0-3.821-.189-8.296 1.419-12.714 8.25-16.67 1.157-.67 2.896-1.68 4.211-2.439 1.316-.759 3.339-2.562 3.339-6.011z" fill="#8cecff"/><g fill="#c2f5ff"><path d="m37.945 44.942c0-2.566-1.593-4.568-3.121-5.453-.017-.01-.018-.009-15.781-9.138-3.856-2.234-7.53 1.065-7.53 4.777v36.209c0 2.569 1.658 4.588 2.922 5.32.701.407-.151-.087 16.153 9.355 2.968 1.719 7.357-.436 7.357-4.8 0-37.016 0-35.524 0-36.27z"/><path d="m50.086 3.383c-2.005-1.207-4.383-1.363-6.421-.212l-19.145 11.176c-3.121 1.808-4.404 6.993-.945 8.996 9.287 5.379 12.698 7.356 15.009 8.694 2.1 1.216 4.72 1.284 6.82.068 6.18-3.579-6.209 3.528 19.258-11.221 3.174-1.839 3.873-6.814.408-8.821-8.96-5.19-12.626-7.26-14.984-8.68z"/></g></svg> No newline at end of file
<svg width="188" height="232" viewBox="0 0 188 232" fill="none" xmlns="http://www.w3.org/2000/svg">
<path fill-rule="evenodd" clip-rule="evenodd" d="M187.356 62.363C187.356 50.5905 173.994 42.7582 163.78 48.6447L91.7886 90.3039C87.6067 92.9588 84.8172 97.9822 84.625 102.4V220.123C84.625 228.789 93.9181 234.841 102.476 230.447L141.341 207.815C146.902 204.209 148.898 199.359 148.898 194.681C148.898 194.681 148.95 187.576 148.898 185.39C148.438 165.22 152.352 154.478 168.979 144.859C171.795 143.23 176.028 140.774 179.229 138.929C182.432 137.083 187.356 132.7 187.356 124.314V62.363Z" fill="white"/>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-square favicon will render distorted in browsers

Low Severity

The new favicon SVG has a non-square aspect ratio (188×232, roughly 4:5) while the old one was square (100×100). Browser favicon slots are square (16×16, 32×32, etc.), so a non-square source image may be stretched, squished, or unevenly cropped depending on the browser, resulting in a distorted icon in tabs and bookmarks.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit f5f1a9b. Configure here.

@VictorLeach96
VictorLeach96 merged commit 35f0a08 into main Apr 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants