Skip to content

Providing more information in case of AudienceRestrictions conditions not satisfied #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
c00kiemon5ter merged 2 commits into from
Feb 2, 2020
Merged

Providing more information in case of AudienceRestrictions conditions not satisfied #664

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c01913c
Update response.py
rristow Jan 31, 2020
92dbdd7
Merge pull request #1 from rristow/rristow-patch-1
rristow Jan 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/saml2/response.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,10 +212,8 @@ def for_me(conditions, myself):
if audience.text.strip() == myself:
return True
else:
# print("Not for me: %s != %s" % (audience.text.strip(),
# myself))
pass

logger.debug("AudienceRestriction - One condition not satisfied: %s != %s" % (audience.text.strip(), myself))
logger.debug("AudienceRestrictions not satisfied!")
return False


Expand Down Expand Up @@ -613,7 +611,7 @@ def condition_ok(self, lax=False):

if not for_me(conditions, self.entity_id):
if not lax:
raise Exception("Not for me!!!")
raise Exception("AudienceRestrictions conditions not satisfied! (Local entity_id=%s)" % self.entity_id)

if conditions.condition: # extra conditions
for cond in conditions.condition:
Expand Down