-
Notifications
You must be signed in to change notification settings - Fork 446
[Documentation] Additional paramenters #715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Documentation] Additional paramenters #715
Conversation
Codecov Report
@@ Coverage Diff @@
## master #715 +/- ##
=======================================
Coverage 65.46% 65.46%
=======================================
Files 102 102
Lines 25501 25501
=======================================
Hits 16695 16695
Misses 8806 8806 Continue to review full report at Codecov.
|
|
In the second commit I added all the things I learned in the past two years of pysaml2 usage.
This commit also close this: |
8984de7 to
62f88d7
Compare
Signed-off-by: Ivan Kanakarakis <ivan.kanak@gmail.com>
62f88d7 to
351bb6a
Compare
| """""""""""""""""""""""""""""""""""""""" | ||
|
|
||
| When verifying a signed AuthnRequest ignore the signature and verify the | ||
| certificate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this configuration option should be removed in the future. We should always be verifying the signature.
|
|
||
| If set to False, the certificate contained in a SAML message will be used for | ||
| signature verification. | ||
| Default True. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this configuration option should be removed in the future. We should not be using anything but the certificates we know about.
| """""""""""""""""""" | ||
|
|
||
| Indicates that the certificate used in sign SAML messages must be valid. | ||
| Default to False. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this configuration option should change to be True by default.
fixes #710
minor change that hopefully make everyone happy ;)