Skip to content

Conversation

@peppelinux
Copy link
Member

fixes #710
minor change that hopefully make everyone happy ;)

@codecov-commenter
Copy link

Codecov Report

Merging #715 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #715   +/-   ##
=======================================
  Coverage   65.46%   65.46%           
=======================================
  Files         102      102           
  Lines       25501    25501           
=======================================
  Hits        16695    16695           
  Misses       8806     8806           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aeae3a...4883d00. Read the comment docs.

@peppelinux
Copy link
Member Author

In the second commit I added all the things I learned in the past two years of pysaml2 usage.

  • Metadata MDQ/Remote disable_ssl_certificate_validation
  • allow_unknown_attributes
  • want_authn_requests_only_with_valid_cert
  • only_use_keys_in_metadata
  • validate_certificate
  • encryption_keypairs
  • a more detailed section, with examples, for Entity Categories

This commit also close this:
#706

@peppelinux peppelinux changed the title [Documentation] nameid_format example [Documentation] Additional paramenters Sep 6, 2020
@peppelinux peppelinux force-pushed the nameid_format_example branch 5 times, most recently from 8984de7 to 62f88d7 Compare September 7, 2020 09:06
""""""""""""""""""""""""""""""""""""""""

When verifying a signed AuthnRequest ignore the signature and verify the
certificate.
Copy link
Member

@c00kiemon5ter c00kiemon5ter Sep 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this configuration option should be removed in the future. We should always be verifying the signature.


If set to False, the certificate contained in a SAML message will be used for
signature verification.
Default True.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this configuration option should be removed in the future. We should not be using anything but the certificates we know about.

""""""""""""""""""""

Indicates that the certificate used in sign SAML messages must be valid.
Default to False.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this configuration option should change to be True by default.

@c00kiemon5ter c00kiemon5ter merged commit ecc690e into IdentityPython:master Sep 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

documented name_id_format example for SP is part of IDP configuation

3 participants