Skip to content

#1097#1155

Merged
aothms merged 4 commits intoIfcOpenShell:v0.6.0from
gisspace:v0.6.0
Jan 9, 2021
Merged

#1097#1155
aothms merged 4 commits intoIfcOpenShell:v0.6.0from
gisspace:v0.6.0

Conversation

@gisspace
Copy link
Copy Markdown
Contributor

fix:IFC file conversion obj file, some cases will be rotated 90 °

1744197233 and others added 4 commits December 10, 2020 18:44
fix:IFC file conversion obj file, some cases will be rotated 90 °
@aothms aothms merged commit 68767c3 into IfcOpenShell:v0.6.0 Jan 9, 2021
@aothms
Copy link
Copy Markdown
Member

aothms commented Jan 9, 2021

Many thanks and sorry for the delay. Overall this looks pretty good, but I'll make a couple of changes after merging:

  • I'll change the argument to --y_up and keep the default at Z-up. We can't change behaviour so drastically and to keep consistent with other serializers.
  • I'll make a note that it's only applicable to the OBJ serializer. It's not hard to apply to others, but I also don't really see a reason, with Collada for example the convention is documented in the file.

@aothms
Copy link
Copy Markdown
Member

aothms commented Jan 9, 2021

Oh and I changed the conversion to < X Z -Y > in that case it matches the [-Z FORWARD Y UP] default in Blender. Can you double check?

aothms added a commit that referenced this pull request Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants