test(igxPivot): Add more test to increase test coverage

projects/igniteui-angular/src/lib/data-operations/pivot-strategy.ts

@@ -101,7 +101,6 @@ export class PivotColumnDimensionsStrategy implements IPivotDimensionStrategy {
                     })
                 }
             });
-
         }
         this.applyAggregates(rec, columns, values, pivotKeys);
     }
@@ -123,10 +122,6 @@ export class PivotColumnDimensionsStrategy implements IPivotDimensionStrategy {
         }
         return leafs;
     }
-
-    private isLeaf(record, pivotKeys) {
-        return !(record[pivotKeys.records] && record[pivotKeys.records].some(r => r[pivotKeys.records]));
-    }
 }
 
 export class DimensionValuesFilteringStrategy extends FilteringStrategy {

projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-grid-keyboard-nav.spec.ts

@@ -52,6 +52,16 @@ describe('IgxPivotGrid - Keyboard navigation #pivotGrid', () => {
         GridFunctions.verifyHeaderIsFocused(secondCell.parent);
         activeCells = fixture.debugElement.queryAll(By.css(`${ACTIVE_CELL_CSS_CLASS}`));
         expect(activeCells.length).toBe(1);
+
+        // should do nothing if wrong key is pressed
+        UIInteractions.simulateClickAndSelectEvent(firstCell);
+        fixture.detectChanges();
+        GridFunctions.verifyHeaderIsFocused(firstCell.parent);
+        activeCells = fixture.debugElement.queryAll(By.css(`${ACTIVE_CELL_CSS_CLASS}`));
+        expect(activeCells.length).toBe(1);
+        UIInteractions.triggerKeyDownEvtUponElem('h', firstCell.nativeElement);
+        fixture.detectChanges();
+        GridFunctions.verifyHeaderIsFocused(firstCell.parent);
     });
 
     it('should not go outside of the boundaries of the row dimensions content', () => {
@@ -119,6 +129,39 @@ describe('IgxPivotGrid - Keyboard navigation #pivotGrid', () => {
         expect(activeCells.length).toBe(1);
     });
 
+    it('should allow navigating from any to first row headers(Ctrl + ArrowUp)', () => {
+        // Ctrl + arrowup
+        let allGroups = fixture.debugElement.queryAll(
+            By.directive(IgxPivotRowDimensionHeaderComponent));
+        const thirdCell = allGroups.filter(x => x.componentInstance.column.field === 'ProductCategory')[2]
+        UIInteractions.simulateClickAndSelectEvent(thirdCell);
+        fixture.detectChanges();
+
+        UIInteractions.triggerKeyDownEvtUponElem('ArrowUp', thirdCell.nativeElement, true, false, false, true);
+        fixture.detectChanges();
+
+        allGroups = fixture.debugElement.queryAll(
+            By.directive(IgxPivotRowDimensionHeaderComponent));
+        const firstCell = allGroups[0];
+        GridFunctions.verifyHeaderIsFocused(firstCell.parent);
+        let activeCells = fixture.debugElement.queryAll(By.css(`${ACTIVE_CELL_CSS_CLASS}`));
+        expect(activeCells.length).toBe(1);
+
+        // just arrow up
+        UIInteractions.simulateClickAndSelectEvent(thirdCell);
+        fixture.detectChanges();
+
+        UIInteractions.triggerKeyDownEvtUponElem('ArrowUp', thirdCell.nativeElement, true, false, false, false);
+        fixture.detectChanges();
+        allGroups = fixture.debugElement.queryAll(
+            By.directive(IgxPivotRowDimensionHeaderComponent));
+        const secondCell = allGroups.filter(x => x.componentInstance.column.field === 'ProductCategory')[1];
+        GridFunctions.verifyHeaderIsFocused(secondCell.parent);
+        activeCells = fixture.debugElement.queryAll(By.css(`${ACTIVE_CELL_CSS_CLASS}`));
+        expect(activeCells.length).toBe(1);
+
+    });
+
     it('should allow navigating between column headers', () => {
         let firstHeader = fixture.debugElement.queryAll(
             By.css(`${PIVOT_HEADER_ROW} ${HEADER_CELL_CSS_CLASS}`))[0];
@@ -133,7 +176,7 @@ describe('IgxPivotGrid - Keyboard navigation #pivotGrid', () => {
 
         UIInteractions.triggerKeyDownEvtUponElem('ArrowRight', pivotGrid.theadRow.nativeElement);
         fixture.detectChanges();
-        
+
         const secondHeader = fixture.debugElement.queryAll(
             By.css(`${PIVOT_HEADER_ROW} ${HEADER_CELL_CSS_CLASS}`))[1];
         GridFunctions.verifyHeaderIsFocused(secondHeader.parent);
@@ -191,4 +234,33 @@ describe('IgxPivotGrid - Keyboard navigation #pivotGrid', () => {
         activeCells = fixture.debugElement.queryAll(By.css(`${ACTIVE_CELL_CSS_CLASS}`));
         expect(activeCells.length).toBe(1);
     });
+
+    it('should allow navigating within the cells of the body', async () => {
+        const cell = pivotGrid.rowList.first.cells.first;
+        GridFunctions.focusFirstCell(fixture, pivotGrid);
+        fixture.detectChanges();
+        expect(pivotGrid.navigation.activeNode.row).toBeUndefined();
+        expect(pivotGrid.navigation.activeNode.column).toBeUndefined();
+
+        UIInteractions.simulateClickAndSelectEvent(cell.nativeElement);
+        fixture.detectChanges();
+
+        GridFunctions.focusFirstCell(fixture, pivotGrid);
+        fixture.detectChanges();
+        expect(pivotGrid.navigation.activeNode.row).toBeDefined();
+        expect(pivotGrid.navigation.activeNode.column).toBeDefined();
+
+        let  activeCells = fixture.debugElement.queryAll(By.css(`.igx-grid__td--active`));
+        expect(activeCells.length).toBe(1);
+        expect(cell.column.field).toEqual('Stanley-UnitsSold');
+
+        const gridContent = GridFunctions.getGridContent(fixture);
+        UIInteractions.triggerEventHandlerKeyDown('arrowright', gridContent);
+        await wait(30);
+        fixture.detectChanges();
+
+        activeCells = fixture.debugElement.queryAll(By.css(`.igx-grid__td--active`));
+        expect(activeCells.length).toBe(1);
+        expect(activeCells[0].componentInstance.column.field).toEqual('Stanley-UnitPrice')
+    });
 });

projects/igniteui-angular/src/lib/grids/pivot-grid/pivot-grid.component.ts

@@ -788,7 +788,7 @@ export class IgxPivotGridComponent extends IgxGridBaseDirective implements OnIni
     }
 
     public get selectedRows(): any[] {
-        if (!this.selectionService.getSelectedRows()) {
+        if (this.selectionService.getSelectedRows().length === 0) {
             return [];
         }
         const selectedRowIds = [];
@@ -2029,13 +2029,6 @@ export class IgxPivotGridComponent extends IgxGridBaseDirective implements OnIni
         return cols;
     }
 
-    /**
-    * @hidden @internal
-    */
-    public getPropName(dim: IPivotDimension) {
-        return !!dim ?? dim.memberName + this.pivotKeys.rowDimensionSeparator + 'height';
-    }
-
     /**
     * @hidden @internal
     */