Skip to content

fix(grid): add case for dateTime #11195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 14, 2022
Merged

fix(grid): add case for dateTime #11195

merged 7 commits into from
Mar 14, 2022

Conversation

@Volen99
Copy link
Contributor

@Volen99 Volen99 commented Mar 8, 2022 •
edited
Loading

Closes #11139

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@Volen99 Volen99 requested a review from hanastasov March 8, 2022 13:04
@Volen99 Volen99 added the 🐛 bug Any issue that describes a bug label Mar 8, 2022
@hanastasov hanastasov added the ❌ status: awaiting-test PRs awaiting manual verification label Mar 10, 2022
@hanastasov hanastasov self-requested a review March 11, 2022 06:52
hanastasov
hanastasov requested changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@hanastasov hanastasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test for it.

@hanastasov hanastasov added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Mar 11, 2022
@hanastasov hanastasov merged commit 38778e6 into 13.1.x Mar 14, 2022
@hanastasov hanastasov deleted the VDyulgerov/fix-GridState-Load-13.1.x branch March 14, 2022 07:48
This was referenced Mar 15, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hanastasov hanastasov hanastasov requested changes

Assignees

No one assigned

Labels

🐛 bug Any issue that describes a bug ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Volen99 @hanastasov @dobromirts