Skip to content

fix(grid): Fix errors thrown when grid is grouped by a column that isn't defined - 13.1.x #11268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 29, 2022
Merged

fix(grid): Fix errors thrown when grid is grouped by a column that isn't defined - 13.1.x #11268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5250fd7
fix(grid): Fix errors thrown when grid is grouped by a column that is…
viktorkombov Mar 22, 2022
44ee106
Merge branch '13.1.x' into vkombov/fix-10619-13.1.x
teodosiah Mar 24, 2022
9aa8639
Merge branch '13.1.x' into vkombov/fix-10619-13.1.x
teodosiah Mar 25, 2022
fb46410
Merge branch '13.1.x' into vkombov/fix-10619-13.1.x
teodosiah Mar 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions projects/igniteui-angular/src/lib/grids/grid/column-group.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,21 @@ describe('IgxGrid - multi-column headers #grid', () => {
expect(grid.columnList.length).toEqual(10);
});

it('There shouldn\'t be any errors when the grid is grouped by a column that isn\'t defined', () => {
fixture = TestBed.createComponent(ColumnGroupTestComponent);
fixture.componentInstance.hideGroupedColumns = true;
fixture.detectChanges();
grid = fixture.componentInstance.grid;

expect(() => {
grid.groupBy({
fieldName: 'NonExistentFieldName', dir: SortingDirection.Desc, ignoreCase: false,
strategy: DefaultSortingStrategy.instance()
});
fixture.detectChanges();
}).not.toThrow();
});

it('should set title attribute on column group header spans', () => {
fixture = TestBed.createComponent(ColumnGroupTestComponent);
fixture.detectChanges();
Expand Down
4 changes: 3 additions & 1 deletion projects/igniteui-angular/src/lib/grids/grid/grid.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -979,7 +979,9 @@ export class IgxGridComponent extends IgxGridBaseDirective implements GridType,
if (changes && this.columnList.length > 0) {
changes.forEachAddedItem((rec) => {
const col = this.getColumnByName(rec.item.fieldName);
col.hidden = true;
if (col) {
col.hidden = true;
}
});
changes.forEachRemovedItem((rec) => {
const col = this.getColumnByName(rec.item.fieldName);
Expand Down
2 changes: 1 addition & 1 deletion projects/igniteui-angular/src/lib/grids/grouping/group-by-area.directive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,6 @@ export class IgxGroupByMetaPipe implements PipeTransform {

public transform(key: string, grid: GridType) {
const column = grid.getColumnByName(key);
return { groupable: column.groupable, title: column.header || key };
return { groupable: !!column?.groupable, title: column?.header || key };
}
}
4 changes: 3 additions & 1 deletion projects/igniteui-angular/src/lib/test-utils/grid-mch-sample.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export class OneGroupThreeColsGridComponent {

@Component({
template: `
<igx-grid #grid [data]="data" height="500px">
<igx-grid #grid [data]="data" height="500px" [hideGroupedColumns]="hideGroupedColumns">
<igx-column field="ID"></igx-column>
<igx-column-group header="General Information">
<igx-column [filterable]="true" [sortable]="true" [resizable]="true" field="CompanyName"></igx-column>
Expand Down Expand Up @@ -82,6 +82,8 @@ export class ColumnGroupTestComponent {
public emptyColGroup: IgxColumnGroupComponent;

public data = SampleTestData.contactInfoDataFull();

public hideGroupedColumns = false;
}

@Component({
Expand Down