Skip to content

fix(gridToolbarHiding): fix columnsAreaMaxHeight input property #11507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 11, 2022
Merged

fix(gridToolbarHiding): fix columnsAreaMaxHeight input property #11507

merged 3 commits into from
May 11, 2022

Conversation

@Volen99
Copy link
Contributor

@Volen99 Volen99 commented May 10, 2022 •
edited
Loading

Closes #10529

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@Volen99 Volen99 requested a review from hanastasov May 10, 2022 10:13
@katherinedragieva katherinedragieva linked an issue May 10, 2022 that may be closed by this pull request
The columnsAreaMaxHeight input property of IgxGridToolbarHiding and IgxGridToolbarPinning is not working as expected #10529
Closed
@katherinedragieva katherinedragieva self-assigned this May 11, 2022
@katherinedragieva katherinedragieva added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed ❌ status: awaiting-test PRs awaiting manual verification labels May 11, 2022
@hanastasov hanastasov added ✅ status: verified Applies to PRs that have passed manual verification and removed ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. labels May 11, 2022
@hanastasov hanastasov merged commit 12de353 into 12.3.x May 11, 2022
@hanastasov hanastasov deleted the VDyulgerov/fix-columnsAreaMaxHeight-input-propert-12.3.x branch May 11, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hanastasov hanastasov hanastasov approved these changes

+1 more reviewer

@katherinedragieva katherinedragieva katherinedragieva approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@katherinedragieva katherinedragieva

Labels

grid: toolbar grid: toolbar-hiding grid: toolbar-pinning version: 12.3.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The columnsAreaMaxHeight input property of IgxGridToolbarHiding and IgxGridToolbarPinning is not working as expected

4 participants

@Volen99 @hanastasov @katherinedragieva