Skip to content

fix(drag): Filter out parent dom elements from shadow elements when gеtting elements from point. #11925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2022
Merged

fix(drag): Filter out parent dom elements from shadow elements when gеtting elements from point. #11925

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions projects/igniteui-angular/src/lib/directives/drag-drop/drag-drop.directive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1216,7 +1216,7 @@ export class IgxDragDirective implements AfterContentInit, OnDestroy {
// Check for shadowRoot instance and use it if present
for (const elFromPoint of elementsFromPoint) {
if (!!elFromPoint?.shadowRoot) {
targetElements = targetElements.concat(this.getFromShadowRoot(elFromPoint, pageX, pageY));
targetElements = targetElements.concat(this.getFromShadowRoot(elFromPoint, pageX, pageY, elementsFromPoint));
} else if (targetElements.indexOf(elFromPoint) === -1) {
targetElements.push(elFromPoint);
}
Expand Down Expand Up @@ -1253,13 +1253,15 @@ export class IgxDragDirective implements AfterContentInit, OnDestroy {
* @hidden
* Traverse shadow dom in depth.
*/
protected getFromShadowRoot(elem, pageX, pageY) {
protected getFromShadowRoot(elem, pageX, pageY, parentDomElems) {
const elementsFromPoint = elem.shadowRoot.elementsFromPoint(pageX, pageY);
let res = elementsFromPoint;
for (const elFromPoint of elementsFromPoint) {
const shadowElements = elementsFromPoint.filter(cur => parentDomElems.indexOf(cur) === -1);
let res = [];
for (const elFromPoint of shadowElements) {
if (!!elFromPoint?.shadowRoot && elFromPoint.shadowRoot !== elem.shadowRoot) {
res = res.concat(this.getFromShadowRoot(elFromPoint, pageX, pageY));
res = res.concat(this.getFromShadowRoot(elFromPoint, pageX, pageY, elementsFromPoint));
}
res.push(elFromPoint);
}
return res;
}
Expand Down