Skip to content

Conversation

@didimmova
Copy link
Contributor

Closes #15591

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@didimmova didimmova added ❌ status: awaiting-test PRs awaiting manual verification tabs ✨ themes labels Apr 10, 2025
@didimmova didimmova requested a review from simeonoff April 10, 2025 12:14
@didimmova didimmova linked an issue Apr 10, 2025 that may be closed by this pull request
Copy link
Collaborator

@SisIvanova SisIvanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure the arrow buttons foreground in all themes is always contrast to the background.

$custom-theme: tabs-theme(
$button-background: #b51075,
$item-text-color: #b51075,
);

Screenshot 2025-04-22 at 1 39 41 PM

@SisIvanova SisIvanova added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Apr 22, 2025
@didimmova didimmova requested a review from SisIvanova April 22, 2025 11:35
@SisIvanova SisIvanova added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Apr 22, 2025
@simeonoff simeonoff merged commit 2189c67 into didimmova/improve-component-themes Apr 25, 2025
@simeonoff simeonoff deleted the didimmova/improve-tabs-theme branch April 25, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ themes tabs ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Tabs Theme

4 participants