fix(grid): address null TypeError on focusing a grid with no data and column headers - 20.1.x #16521
+23
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddaribo
force-pushed
the
bpachilova/ariaHidden-header-groups-fix-16517-20.1.x
branch
from
23b18a9 to
5d78e4e
Compare
Copilot finished reviewing on behalf of
ddaribo
November 26, 2025 09:44
ddaribo
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a null TypeError that occurs when focusing a grid with no data and column headers, addressing issue #16517. The fix adds optional chaining to safely handle cases where activeNode may be null.
- Added optional chaining (
?.) to two header component getters that accessnavigation.activeNode.row - Added a unit test to verify the fix prevents the TypeError when focusing an empty grid
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| grid-header-row.component.ts | Added optional chaining to isLeafHeaderAriaHidden getter to handle null activeNode |
| grid-header-group.component.ts | Added optional chaining to ariaHidden getter to handle null activeNode |
| column-group.spec.ts | Added test case to verify the fix prevents TypeError when grid has no active node |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kacheshmarova
approved these changes
Nov 26, 2025
IvanKitanov17
added
💥 status: in-test
kacheshmarova
deleted the
bpachilova/ariaHidden-header-groups-fix-16517-20.1.x
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16517
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)