fix(grid): address null TypeError on focusing a grid with no data and column headers - 19.2.x #16522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a TypeError that occurs when focusing a grid with no data and column headers. The issue was that activeNode can be null in certain scenarios, causing a null reference error when accessing its row property.
- Added optional chaining to prevent null reference errors when accessing
activeNode.row - Included comprehensive test coverage for the bug fix
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
projects/igniteui-angular/src/lib/grids/headers/grid-header-row.component.ts |
Added optional chaining to activeNode?.row in the isLeafHeaderAriaHidden getter to prevent TypeError when activeNode is null |
projects/igniteui-angular/src/lib/grids/headers/grid-header-group.component.ts |
Added optional chaining to activeNode?.row in the ariaHidden getter to prevent TypeError when activeNode is null |
projects/igniteui-angular/src/lib/grids/grid/column-group.spec.ts |
Added test case to verify that the ariaHidden getters do not throw errors when grid has no active node (empty data + focus on grid body) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kacheshmarova
approved these changes
Nov 26, 2025
IvanKitanov17
added
💥 status: in-test
kacheshmarova
deleted the
bpachilova/ariaHidden-header-groups-fix-16517-19.2.x
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16517
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)