Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 27, 2025

Restores the IGX_GRID_ACTION_STRIP_DIRECTIVES constant that was removed during the refactoring to multiple entry points.

The constant is now exported from igniteui-angular/grids/core and includes:

  • Base action strip components: IgxActionStripComponent, IgxActionStripMenuItemDirective
  • Grid-specific components: IgxGridPinningActionsComponent, IgxGridEditingActionsComponent, IgxGridActionsBaseDirective, IgxGridActionButtonComponent

Changes Made

  • Added IGX_GRID_ACTION_STRIP_DIRECTIVES constant to grids/core/src/public_api.ts
  • Added import migration mapping for IGX_GRID_ACTION_STRIP_DIRECTIVESigniteui-angular/grids/core
  • Updated CHANGELOG.md with component relocation note

This ensures users who were using IGX_GRID_ACTION_STRIP_DIRECTIVES from the old igniteui-angular package can continue to use it from the new igniteui-angular/grids/core entry point, and the ng update migration will automatically update their imports.

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them
Original prompt

fix: add an angular migration and update CHANGLOG.md for the rename of IGX_GRID_ACTION_STRIP_DIRECTIVES to IGX_ACTION_STRIP_DIRECTIVES

Use the classes.json like here: https://github.com/IgniteUI/igniteui-angular/blob/master/projects/igniteui-angular/migrations/update-21_0_0/changes/classes.json


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…CHANGELOG

Co-authored-by: Lipata <2621802+Lipata@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix angular migration and update changelog for directive rename fix: add migration for IGX_GRID_ACTION_STRIP_DIRECTIVES rename to IGX_ACTION_STRIP_DIRECTIVES Nov 27, 2025
Copilot finished work on behalf of Lipata November 27, 2025 12:31
Copilot AI requested a review from Lipata November 27, 2025 12:31
@Lipata Lipata marked this pull request as ready for review November 27, 2025 12:51
@Lipata Lipata requested review from damyanpetev and kdinev November 27, 2025 13:09
@damyanpetev
Copy link
Member

Not entirely sure of the order of migrations at this point, IIRC there's a renamed types handling in the update-21_0_0_import-migration though if normal renames run first this should be fine.

PS: This change can be made non-breaking with an alias import, though I don't see usage in the samples, so it might not be worth it.

@damyanpetev
Copy link
Member

Oh actually I found this in the docs
https://www.infragistics.com/products/ignite-ui-angular/angular/components/action-strip#getting-started-with-ignite-ui-for-angular-action-strip
mentioning IGX_ACTION_STRIP_DIRECTIVES and went looking and it seems that was a thing in 20.1.x

/* Action-strip outside of grid directives collection for ease-of-use import in standalone components scenario */
export const IGX_ACTION_STRIP_DIRECTIVES = [
IgxActionStripComponent,
IgxActionStripMenuItemDirective
] as const;
/* Action-strip in grid directives collection for ease-of-use import in standalone components scenario */
export const IGX_GRID_ACTION_STRIP_DIRECTIVES = [
IgxActionStripComponent,
IgxActionStripMenuItemDirective,
IgxGridPinningActionsComponent,
IgxGridEditingActionsComponent,
IgxGridActionsBaseDirective,
IgxGridActionButtonComponent
] as const;

So um, the change seems more like a loss of the IGX_GRID_ACTION_STRIP_DIRECTIVES rather than a rename? That seems to be rolled into the GRID_COMMON and change to the IgxActionStripModule since that doesn't provide all those anymore, though it hardly will matter in real usage I think.

@Lipata
Copy link
Member

Lipata commented Nov 28, 2025

IGX_GRID_ACTION_STRIP_DIRECTIVES adds some grid components, like: IgxGridPinningActionsComponent, IgxGridEditingActionsComponent, so when changing to IGX_ACTION_STRIP_DIRECTIVES, it is required that those packages or a constant that includes the latter be imported also. @copilot this seems a bug rather than a missing breaking change note. Can you try to resolve it?

The migration was incorrect because IGX_GRID_ACTION_STRIP_DIRECTIVES and
IGX_ACTION_STRIP_DIRECTIVES contain different components. The former
includes grid-specific components (IgxGridPinningActionsComponent,
IgxGridEditingActionsComponent, etc.) while the latter only contains
base action strip components.

Co-authored-by: Lipata <2621802+Lipata@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Nov 28, 2025

IGX_GRID_ACTION_STRIP_DIRECTIVES adds some grid components, like: IgxGridPinningActionsComponent, IgxGridEditingActionsComponent, so when changing to IGX_ACTION_STRIP_DIRECTIVES, it is require...

You're right. I've reverted the migration in commit 76aa9bb. IGX_GRID_ACTION_STRIP_DIRECTIVES contains grid-specific components (IgxGridPinningActionsComponent, IgxGridEditingActionsComponent, etc.) while IGX_ACTION_STRIP_DIRECTIVES only contains base action strip components (IgxActionStripComponent, IgxActionStripMenuItemDirective). These are different constants, not a rename, so a class migration would be incorrect.

Copilot AI changed the title fix: add migration for IGX_GRID_ACTION_STRIP_DIRECTIVES rename to IGX_ACTION_STRIP_DIRECTIVES Revert incorrect migration for IGX_GRID_ACTION_STRIP_DIRECTIVES to IGX_ACTION_STRIP_DIRECTIVES Nov 28, 2025
Copilot finished work on behalf of Lipata November 28, 2025 10:12
@Lipata
Copy link
Member

Lipata commented Nov 28, 2025

@copilot can you work on resolving the issue itself - keep IGX_GRID_ACTION_STRIP_DIRECTIVES or use another constants along with the IGX_ACTION_STRIP_DIRECTIVES, when used in the igx-grid

- Export IGX_GRID_ACTION_STRIP_DIRECTIVES from igniteui-angular/grids/core
- Add import migration for IGX_GRID_ACTION_STRIP_DIRECTIVES
- Update CHANGELOG.md with component relocation note

Co-authored-by: Lipata <2621802+Lipata@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Nov 28, 2025

@copilot can you work on resolving the issue itself - keep IGX_GRID_ACTION_STRIP_DIRECTIVES or use another constants along with the IGX_ACTION_STRIP_DIRECTIVES, when used in the igx-grid

Restored IGX_GRID_ACTION_STRIP_DIRECTIVES in commit 705cc79. The constant is now exported from igniteui-angular/grids/core and includes both base action strip components (IgxActionStripComponent, IgxActionStripMenuItemDirective) and grid-specific components (IgxGridPinningActionsComponent, IgxGridEditingActionsComponent, IgxGridActionsBaseDirective, IgxGridActionButtonComponent). Also added the import migration to update existing imports automatically.

Copilot AI changed the title Revert incorrect migration for IGX_GRID_ACTION_STRIP_DIRECTIVES to IGX_ACTION_STRIP_DIRECTIVES Add IGX_GRID_ACTION_STRIP_DIRECTIVES constant to grids/core entry point Nov 28, 2025
Copilot finished work on behalf of Lipata November 28, 2025 10:43
@damyanpetev
Copy link
Member

damyanpetev commented Dec 1, 2025

@Lipata , okay, so one other issue with this - IGX_GRID_ACTION_STRIP_DIRECTIVES is supposed to be IGX_GRID_COMMON_DIRECTIVES where these are included at the end, however that instructs to use IGX_GRID_DIRECTIVES instead, but the common list is not fully there since we had to manually repeat - specifically the action strip actions at the end are missing for sure. Point being, if this is supposed to be included with grid directives and just work out of the box - perhaps that's the usage we go for. Honestly, not sure what happened there, need to track changes and the docs really don't help.

@Lipata
Copy link
Member

Lipata commented Dec 2, 2025

closing in favor of: #16573

@Lipata Lipata closed this Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants