-
Notifications
You must be signed in to change notification settings - Fork 156
Add IGX_GRID_ACTION_STRIP_DIRECTIVES constant to grids/core entry point #16532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…CHANGELOG Co-authored-by: Lipata <2621802+Lipata@users.noreply.github.com>
|
Not entirely sure of the order of migrations at this point, IIRC there's a renamed types handling in the PS: This change can be made non-breaking with an alias import, though I don't see usage in the samples, so it might not be worth it. |
|
Oh actually I found this in the docs igniteui-angular/projects/igniteui-angular/src/lib/action-strip/public_api.ts Lines 13 to 27 in f96df58
So um, the change seems more like a loss of the |
|
|
The migration was incorrect because IGX_GRID_ACTION_STRIP_DIRECTIVES and IGX_ACTION_STRIP_DIRECTIVES contain different components. The former includes grid-specific components (IgxGridPinningActionsComponent, IgxGridEditingActionsComponent, etc.) while the latter only contains base action strip components. Co-authored-by: Lipata <2621802+Lipata@users.noreply.github.com>
You're right. I've reverted the migration in commit 76aa9bb. |
|
@copilot can you work on resolving the issue itself - keep IGX_GRID_ACTION_STRIP_DIRECTIVES or use another constants along with the IGX_ACTION_STRIP_DIRECTIVES, when used in the igx-grid |
- Export IGX_GRID_ACTION_STRIP_DIRECTIVES from igniteui-angular/grids/core - Add import migration for IGX_GRID_ACTION_STRIP_DIRECTIVES - Update CHANGELOG.md with component relocation note Co-authored-by: Lipata <2621802+Lipata@users.noreply.github.com>
Restored |
|
@Lipata , okay, so one other issue with this - |
|
closing in favor of: #16573 |
Restores the
IGX_GRID_ACTION_STRIP_DIRECTIVESconstant that was removed during the refactoring to multiple entry points.The constant is now exported from
igniteui-angular/grids/coreand includes:IgxActionStripComponent,IgxActionStripMenuItemDirectiveIgxGridPinningActionsComponent,IgxGridEditingActionsComponent,IgxGridActionsBaseDirective,IgxGridActionButtonComponentChanges Made
IGX_GRID_ACTION_STRIP_DIRECTIVESconstant togrids/core/src/public_api.tsIGX_GRID_ACTION_STRIP_DIRECTIVES→igniteui-angular/grids/coreCHANGELOG.mdwith component relocation noteThis ensures users who were using
IGX_GRID_ACTION_STRIP_DIRECTIVESfrom the oldigniteui-angularpackage can continue to use it from the newigniteui-angular/grids/coreentry point, and theng updatemigration will automatically update their imports.Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.