Skip to content

fix(list): styling discrepancies #16567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChronosSF merged 3 commits into from
Dec 3, 2025
Merged

fix(list): styling discrepancies #16567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b3e7c34
fix(list): styling discrepancies
SisIvanova Dec 1, 2025
74b545b
fix(list): selected & hover styles
SisIvanova Dec 2, 2025
03de448
Merge branch '20.1.x' into sivanova/list-styling-20.1.x
SisIvanova Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 35 additions & 31 deletions projects/igniteui-angular/src/lib/core/styles/components/list/_list-theme.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
border-radius: var-get($theme, 'border-radius');

@if $variant == 'bootstrap' {
border: rem(1px) solid var-get($theme, 'border-color');
border: var-get($theme, 'border-width') solid var-get($theme, 'border-color');
}

&:focus-visible {
Expand Down Expand Up @@ -137,43 +137,48 @@
justify-content: center;
border-radius: var-get($theme, 'item-border-radius');
color: var-get($theme, 'item-text-color');
border-bottom: var-get($theme, 'border-width') solid var-get($theme, 'border-color');

@if $bootstrap-theme or $variant == 'fluent' {
border-bottom: var-get($theme, 'border-width') solid var-get($theme, 'border-color');

&:last-of-type {
border-bottom: none;
}
&:last-of-type {
border-bottom: none;
}
}

&:hover {
%igx-list-item-base:not(%igx-list-item-base--selected) {
&:hover,
&:focus-within {
%igx-list__item-lines {
color: currentColor;
}

%igx-list__item-line-title {
color: var-get($theme, 'item-title-color-hover');
}
%igx-list-item-content:not(%igx-list-item-content--active) {
color: var-get($theme, 'item-text-color-hover');
background: var-get($theme, 'item-background-hover');

%igx-list__item-line-subtitle {
color: var-get($theme, 'item-subtitle-color-hover');
}
%igx-list__item-line-title {
color: var-get($theme, 'item-title-color-hover');
}

%igx-list__item-actions {
color: var-get($theme, 'item-action-color-hover');
%igx-list__item-line-subtitle {
color: var-get($theme, 'item-subtitle-color-hover');
}

igx-icon,
igc-icon {
color: var-get($theme, 'item-action-color-hover')
%igx-list__item-actions {
color: var-get($theme, 'item-action-color-hover');

igx-icon,
igc-icon {
color: var-get($theme, 'item-action-color-hover')
}
}
}

%igx-list__item-thumbnail {
color: var-get($theme, 'item-thumbnail-color-hover');
%igx-list__item-thumbnail {
color: var-get($theme, 'item-thumbnail-color-hover');

igx-icon,
igc-icon {
color: var-get($theme, 'item-thumbnail-color-hover')
igx-icon,
igc-icon {
color: var-get($theme, 'item-thumbnail-color-hover')
}
}
}
}
Expand Down Expand Up @@ -256,12 +261,6 @@
background: var-get($theme, 'item-background');
z-index: 2;
gap: if($variant == 'indigo', rem(8px), rem(16px));

&:hover,
&:focus-within {
color: var-get($theme, 'item-text-color-hover');
background: var-get($theme, 'item-background-hover');
}
}

%igx-list-header,
Expand All @@ -285,6 +284,11 @@
--component-size: #{if($variant == 'indigo', 2, var(--list-size))};
}

igx-icon,
igc-icon {
color: var-get($theme, 'item-thumbnail-color');
}

&:empty {
display: none;
}
Expand Down
4 changes: 2 additions & 2 deletions src/app/list/list.sample.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ <h5 class="sample-title">WC List</h5>
<span>Employees List</span>
</igc-list-header>
@for(employee of employeeItems; track employee){
<igc-list-item>
<igc-list-item [selected]="employee.selected">
@if(properties.addAvatarThumbnail) {
<igc-avatar slot="start" [src]="employee.imageURL"></igc-avatar>
}
Expand All @@ -69,7 +69,7 @@ <h5 class="sample-title">WC List</h5>
<span slot="subtitle">{{employee.position}}</span>
}
@if(properties.addCheckboxAction) {
<igc-checkbox slot="end"></igc-checkbox>
<igc-checkbox slot="end" [checked]="employee.selected"></igc-checkbox>
}
@if(properties.addIconAction) {
<igc-icon slot="end" name="info"></igc-icon>
Expand Down
Loading