fix(grid): keep conditionName in sycn on conditon changed callback [master]#16922
Open
hanastasov wants to merge 3 commits intomasterfrom
Open
fix(grid): keep conditionName in sycn on conditon changed callback [master]#16922hanastasov wants to merge 3 commits intomasterfrom
hanastasov wants to merge 3 commits intomasterfrom
Conversation
Merged
14 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a synchronization issue in the grid filtering system where the conditionName property of filtering expressions was not being kept in sync with the condition.name property when users changed filter conditions through the UI.
Changes:
- Updates filtering UI components to explicitly set both
expression.conditionandexpression.conditionNamewhen conditions change - Changes the priority in expression recreation logic to prefer
conditionNameovercondition.nameas the source of truth - Updates test assertions to verify that
conditionNamematchescondition.name
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| projects/igniteui-angular/grids/grid/src/grid-filtering-ui.spec.ts | Adds test assertions to verify conditionName is properly synchronized when conditions change through the filter row UI |
| projects/igniteui-angular/grids/core/src/filtering/excel-style/excel-style-default-expression.component.ts | Updates onConditionsChanged to set both expression.condition and expression.conditionName |
| projects/igniteui-angular/grids/core/src/filtering/base/grid-filtering-row.component.ts | Updates onConditionsChanged to set both expression.condition and expression.conditionName |
| projects/igniteui-angular/core/src/data-operations/expressions-tree-util.ts | Changes priority from condition.name to conditionName in recreation logic, and preserves existing conditionName values |
| projects/igniteui-angular/core/src/data-operations/expressions-tree-util.spec.ts | Removes test that validated the old behavior where condition.name took precedence over conditionName |
projects/igniteui-angular/core/src/data-operations/expressions-tree-util.ts
Show resolved
Hide resolved
projects/igniteui-angular/core/src/data-operations/expressions-tree-util.ts
Show resolved
Hide resolved
projects/igniteui-angular/core/src/data-operations/expressions-tree-util.spec.ts
Show resolved
Hide resolved
Collaborator
deyvidnenchev
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16841
conditionName was not in sync:
How is fixed:
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)