Skip to content

fix(grid): keep conditionName in sycn on conditon changed callback [master]#16922

Open
hanastasov wants to merge 3 commits intomasterfrom
keep-conditionName-synced-master
Open

fix(grid): keep conditionName in sycn on conditon changed callback [master]#16922
hanastasov wants to merge 3 commits intomasterfrom
keep-conditionName-synced-master

Conversation

@hanastasov
Copy link
Contributor

@hanastasov hanastasov commented Feb 18, 2026

Closes #16841

conditionName was not in sync:

  1. grid default filter mode
  2. ExcelStyleFiltering - custom condition

How is fixed:

  1. onConditionsChanged callback in grid filtering row component -updates it straight away
  2. onConditionsChanged calback in onConditionsChanged ( did not add a test about it, because there was no available TestBed for this component and is not worth doing it atm)

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a synchronization issue in the grid filtering system where the conditionName property of filtering expressions was not being kept in sync with the condition.name property when users changed filter conditions through the UI.

Changes:

  • Updates filtering UI components to explicitly set both expression.condition and expression.conditionName when conditions change
  • Changes the priority in expression recreation logic to prefer conditionName over condition.name as the source of truth
  • Updates test assertions to verify that conditionName matches condition.name

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
projects/igniteui-angular/grids/grid/src/grid-filtering-ui.spec.ts Adds test assertions to verify conditionName is properly synchronized when conditions change through the filter row UI
projects/igniteui-angular/grids/core/src/filtering/excel-style/excel-style-default-expression.component.ts Updates onConditionsChanged to set both expression.condition and expression.conditionName
projects/igniteui-angular/grids/core/src/filtering/base/grid-filtering-row.component.ts Updates onConditionsChanged to set both expression.condition and expression.conditionName
projects/igniteui-angular/core/src/data-operations/expressions-tree-util.ts Changes priority from condition.name to conditionName in recreation logic, and preserves existing conditionName values
projects/igniteui-angular/core/src/data-operations/expressions-tree-util.spec.ts Removes test that validated the old behavior where condition.name took precedence over conditionName

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 91.577%. first build
when pulling 789a45e on keep-conditionName-synced-master
into 5b681a1 on master.

@hanastasov hanastasov changed the title fix(grid): keep conditionName in sycn on conditon changed callback fix(grid): keep conditionName in sycn on conditon changed callback [master] Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Grid State - Extracted filter column state is always set to "contains"

4 participants

Comments