Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands unit test coverage for igniteui-angular-extras (pipes, directives, and context-menu components) and updates the root npm test script to run additional project test suites as part of CI.
Changes:
- Added new and expanded Jasmine specs across multiple extras features (SVG pipe, conditional formatting, chart integration, context menu, chart dialog).
- Added an extras-level
.gitignore. - Updated the root
testscript to run multiple test targets (lib/styles/schematics/i18n/extras/elements), with correspondingpackage-lock.jsonupdates.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| projects/igniteui-angular-extras/src/lib/pipes/svg.pipe.spec.ts | New tests validating SvgPipe output type and sanitizer usage. |
| projects/igniteui-angular-extras/src/lib/directives/conditional-formatting/conditional-formatting.directive.spec.ts | Added boundary/edge-case coverage for formatters (thresholds, non-numeric, range checks). |
| projects/igniteui-angular-extras/src/lib/directives/chart-integration/initializers.spec.ts | Added assertions for initializer seriesType storage. |
| projects/igniteui-angular-extras/src/lib/directives/chart-integration/chart-integration.directive.spec.ts | Added coverage for option-setting, label member path logic, pie exclusion, idempotent enable/disable, scatter line creation. |
| projects/igniteui-angular-extras/src/lib/context-menu/igx-context-menu.directive.spec.ts | Added coverage for destroy/overlay events and additional render edge cases. |
| projects/igniteui-angular-extras/src/lib/context-menu/context-menu.component.spec.ts | Added coverage around destroy behavior, overlay events, constructor init, and tab menu toggling. |
| projects/igniteui-angular-extras/src/lib/context-menu/chart-dialog/chart-dialog.component.spec.ts | Added coverage for ngAfterViewInit, ngOnDestroy, and title formatting edge cases. |
| projects/igniteui-angular-extras/.gitignore | Added ignore rules scoped to the extras project directory. |
| package.json | Updated npm test to run additional test suites (including extras/elements) for CI. |
| package-lock.json | Lockfile updates corresponding to dependency tree / npm metadata changes. |
projects/igniteui-angular-extras/src/lib/context-menu/context-menu.component.spec.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular-extras/src/lib/context-menu/igx-context-menu.directive.spec.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular-extras/src/lib/context-menu/context-menu.component.spec.ts
Outdated
Show resolved
Hide resolved
…menu.component.spec.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ext-menu.directive.spec.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…menu.component.spec.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…i-angular into coverage-extras
added 2 commits
March 27, 2026 11:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)