fix(igxGrid): Add handling for outlet in case actionstrip is added post init#17162
Merged
fix(igxGrid): Add handling for outlet in case actionstrip is added post init#17162
Conversation
MayaKirova
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a grid ActionStrip overlay configuration edge case where the ActionStrip is added after the grid has already completed content initialization, ensuring the ActionStrip menu overlay uses the grid’s outlet.
Changes:
- Subscribe to
actionStripComponents.changesinIgxGridBaseDirective.ngAfterContentInit()and (re)applymenuOverlaySettings.outletwhen an ActionStrip appears later. - Add a dedicated test component that toggles an ActionStrip via control flow (
@if) after initial render. - Add a unit test verifying the dynamically added ActionStrip menu overlay outlet is set to
grid.outlet.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
projects/igniteui-angular/test-utils/grid-samples.spec.ts |
Adds a test-only grid component that can dynamically render an ActionStrip after init. |
projects/igniteui-angular/grids/grid/src/grid-base.directive.ts |
Updates grid lifecycle wiring to re-apply ActionStrip menu outlet when ActionStrip content children change. |
projects/igniteui-angular/grids/grid/src/grid-add-row.spec.ts |
Adds a regression test covering dynamic ActionStrip insertion and outlet assignment. |
dkamburov
added
✅ status: verified
dkamburov
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…st init.
Closes #16850
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)