Skip to content

refactor(migrations): update module output, drop dynamic import helper#17184

Merged
damyanpetev merged 1 commit intosstoychev/fix-migrations-ng21from
dpetev/migrations-drop-import-helper
Apr 16, 2026
Merged

refactor(migrations): update module output, drop dynamic import helper#17184
damyanpetev merged 1 commit intosstoychev/fix-migrations-ng21from
dpetev/migrations-drop-import-helper

Conversation

@damyanpetev
Copy link
Copy Markdown
Member

Closes #

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the Ignite UI for Angular schematics/migrations build output to support native dynamic imports, removing the legacy nativeImport helper and switching TS module output to node16.

Changes:

  • Switch projects/igniteui-angular/{schematics,migrations}/tsconfig.json from commonjs to node16.
  • Replace nativeImport('@angular/compiler') with native await import('@angular/compiler') across multiple migration entrypoints.
  • Remove the obsolete migrations/common/import-helper.js.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
projects/igniteui-angular/schematics/tsconfig.json Updates TS module emit to node16 for schematics build output.
projects/igniteui-angular/migrations/tsconfig.json Updates TS module emit to node16 for migrations build output.
projects/igniteui-angular/migrations/common/import-helper.js Removes the legacy dynamic import helper.
projects/igniteui-angular/migrations/update-20_0_6/index.ts Drops helper usage and uses native dynamic import for @angular/compiler.
projects/igniteui-angular/migrations/update-18_0_0/index.ts Drops helper usage and uses native dynamic import for @angular/compiler.
projects/igniteui-angular/migrations/update-17_1_0/index.ts Drops helper usage and uses native dynamic import for @angular/compiler.
projects/igniteui-angular/migrations/update-17_0_0/index.ts Drops helper usage and uses native dynamic import for @angular/compiler.
projects/igniteui-angular/migrations/update-16_1_0/index.ts Drops helper usage and uses native dynamic import for @angular/compiler.
projects/igniteui-angular/migrations/update-15_1_0/index.ts Drops helper usage and uses native dynamic import for @angular/compiler.
projects/igniteui-angular/migrations/update-13_1_0/index.ts Drops helper usage and uses native dynamic import for @angular/compiler.
projects/igniteui-angular/migrations/update-13_0_0/index.ts Drops helper usage and uses native dynamic import for @angular/compiler.
projects/igniteui-angular/migrations/update-12_1_0/index.ts Drops helper usage and uses native dynamic import for @angular/compiler.
projects/igniteui-angular/migrations/update-12_0_0/index.ts Drops helper usage and uses native dynamic import for @angular/compiler.
projects/igniteui-angular/migrations/update-11_0_0/index.ts Drops helper usage and uses native dynamic import for @angular/compiler.

Comment thread projects/igniteui-angular/migrations/update-20_0_6/index.ts
Comment thread projects/igniteui-angular/migrations/update-17_1_0/index.ts Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated no new comments.

@damyanpetev damyanpetev force-pushed the dpetev/migrations-drop-import-helper branch from 15986c6 to 0f443c6 Compare April 16, 2026 11:25
@damyanpetev damyanpetev changed the base branch from master to sstoychev/fix-migrations-ng21 April 16, 2026 11:26
@damyanpetev damyanpetev force-pushed the dpetev/migrations-drop-import-helper branch from 0f443c6 to 6dc3099 Compare April 16, 2026 12:47
@damyanpetev damyanpetev merged commit 84a0109 into sstoychev/fix-migrations-ng21 Apr 16, 2026
@damyanpetev damyanpetev deleted the dpetev/migrations-drop-import-helper branch April 16, 2026 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants