fix(chips): update chip padding to contain text padding#17187
Merged
fix(chips): update chip padding to contain text padding#17187
Conversation
simeonoff
added
💥 status: in-test
simeonoff
reviewed
Apr 16, 2026
Collaborator
simeonoff
left a comment
simeonoff
left a comment
There was a problem hiding this comment.
I think we should handle padding in two places here -> in the %igx-chip__content, where the text content goes, the padding should replicate what Figma shows as the padding for the text, while the item should retain the old padding that is put around both the icons and the text.
adrianptrv
added
✅ status: verified
simeonoff
previously approved these changes
Apr 20, 2026
Collaborator
|
@didimmova we need a PR targeting the scoped-styles branch. |
Chips are now wider (have bigger padding on both sides), hence fewer chips are visible in the tests compared to before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17115
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)