Conversation
…cle color property
There was a problem hiding this comment.
Pull request overview
Adds the missing 21.2.0 migration entrypoint and theme-change config so ng update can rename the Circular theme’s circular progress “base circle color” parameter to the new name, addressing the reported ng update errors for 21.2.0.
Changes:
- Introduces the
update-21_2_0migration entrypoint that runsUpdateChangesfor v21.2.0. - Adds a theme change mapping to rename
$base-circle-colorto$track-colorforcircular-theme. - Adds a schematic test validating the SCSS rename behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| projects/igniteui-angular/migrations/update-21_2_0/index.ts | New 21.2.0 migration entrypoint invoking UpdateChanges. |
| projects/igniteui-angular/migrations/update-21_2_0/index.spec.ts | Adds unit test coverage for the SCSS parameter rename migration. |
| projects/igniteui-angular/migrations/update-21_2_0/changes/theme-changes.json | Declares the $base-circle-color → $track-color change for circular-theme. |
| 'circular-theme' | ||
| ]; | ||
| const testFilePath = '/testSrc/appPrefix/component/${theme}.component.scss'; | ||
|
|
There was a problem hiding this comment.
testFilePath is declared with single quotes, so the ${theme} placeholder is never interpolated. This makes the test create/read a literal file named ${theme}.component.scss rather than a theme-specific path, which is misleading and won’t scale if more themes are added. Build the path with a template literal inside the loop (or use a helper function) so it actually includes the current theme value.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Closes #17197
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)