Skip to content

fix(grid): wrap theme-builder selectors in where pseudo selector#17240

Merged
simeonoff merged 2 commits into
masterfrom
didimmova/fix-grid-theme-builder
May 11, 2026
Merged

fix(grid): wrap theme-builder selectors in where pseudo selector#17240
simeonoff merged 2 commits into
masterfrom
didimmova/fix-grid-theme-builder

Conversation

@didimmova
Copy link
Copy Markdown
Contributor

Description

Motivation / Context

Type of Change (check all that apply):

  • Bug fix
  • New functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes)
  • Documentation
  • Demos
  • CI/CD
  • Tests
  • Changelog
  • Skills/Agents

Component(s) / Area(s) Affected:

How Has This Been Tested?

  • Unit tests
  • Manual testing
  • Automated e2e tests

Test Configuration:

  • Angular version:
  • Browser(s):
  • OS:

Screenshots / Recordings

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them
  • Accessibility (ARIA, keyboard navigation, focus management) has been verified

Copilot AI review requested due to automatic review settings May 11, 2026 09:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Grid theme builder’s root selector to wrap all grid component selectors in :where(...), reducing selector specificity while keeping the same matching behavior. This helps theme-generated styles (CSS variables + token overrides) be easier to override downstream without needing higher-specificity selectors.

Changes:

  • Replaced the multi-selector list (igx-grid, igc-grid, ...) with a single :where(igx-grid, igc-grid, ...) selector in the grid theme builder.

@simeonoff simeonoff merged commit e95d9fc into master May 11, 2026
10 checks passed
@simeonoff simeonoff deleted the didimmova/fix-grid-theme-builder branch May 11, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

grid ✨ themes ❌ status: awaiting-test PRs awaiting manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants