Skip to content

feat(badge): update badge example and styles for avatar integration#17241

Merged
kdinev merged 2 commits into21.2.xfrom
mstoyanova/badge-skill-update-21.2.x
Apr 27, 2026
Merged

feat(badge): update badge example and styles for avatar integration#17241
kdinev merged 2 commits into21.2.xfrom
mstoyanova/badge-skill-update-21.2.x

Conversation

@Marina-L-Stoyanova
Copy link
Copy Markdown
Contributor

@Marina-L-Stoyanova Marina-L-Stoyanova commented Apr 27, 2026

Closes #

Description

Motivation / Context

Type of Change (check all that apply):

  • Bug fix
  • New functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes)
  • Documentation
  • Demos
  • CI/CD
  • Tests
  • Changelog
  • Skills/Agents

Component(s) / Area(s) Affected:

How Has This Been Tested?

  • Unit tests
  • Manual testing
  • Automated e2e tests

Test Configuration:

  • Angular version:
  • Browser(s):
  • OS:

Screenshots / Recordings

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them
  • Accessibility (ARIA, keyboard navigation, focus management) has been verified

Copilot AI review requested due to automatic review settings April 27, 2026 10:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Badge + Avatar integration examples to reflect the recommended overlay approach (wrapper container + positioning styles), aligning skill/reference docs and component JSDoc examples.

Changes:

  • Update the Avatar + Badge example markup to wrap both components in an .avatar-badge-container.
  • Add SCSS snippet demonstrating how to position the badge as an overlay on the avatar.
  • Update IgxBadgeComponent JSDoc example to match the new composition pattern.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
skills/igniteui-angular-components/references/data-display.md Updates the Avatar+Badge example and adds required overlay SCSS.
projects/igniteui-angular/badge/src/badge/badge.component.ts Updates component-level JSDoc example to use a wrapper container for Avatar+Badge.

Comment thread skills/igniteui-angular-components/references/data-display.md Outdated
* <igx-avatar icon="person" shape="circle" size="small"></igx-avatar>
* <igx-badge icon="check" type="success" shape="square"></igx-badge>
* </div>
* ```
Copy link

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example switches from projecting the badge into the avatar to placing both in a wrapper div, but it doesn't mention the CSS required to actually overlay the badge (e.g., relative positioning on the container and absolute positioning on the badge). Without that, the example will render the badge next to the avatar rather than as an overlay—please include a brief note and/or reference to the required styles.

Suggested change
* ```
* ```
*
* The wrapper needs positioning styles so the badge is overlaid on the avatar instead of rendering
* next to it:
*
* ```css
* .avatar-badge-container {
* position: relative;
* display: inline-block;
* }
*
* .avatar-badge-container igx-badge {
* position: absolute;
* right: 0;
* bottom: 0;
* }
* ```

Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@kdinev kdinev merged commit f19ba59 into 21.2.x Apr 27, 2026
5 checks passed
@kdinev kdinev deleted the mstoyanova/badge-skill-update-21.2.x branch April 27, 2026 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants