fix(igxGrid): In case zone is already stable emit detect and emit chu…#17269
Open
MayaKirova wants to merge 2 commits into21.2.xfrom
Open
fix(igxGrid): In case zone is already stable emit detect and emit chu…#17269MayaKirova wants to merge 2 commits into21.2.xfrom
MayaKirova wants to merge 2 commits into21.2.xfrom
Conversation
MayaKirova
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a virtualization/navigation edge case in IgxGrid where vertical scrolling can leave NgZone already stable, preventing the chunkLoad emission and causing keyboard navigation (arrow keys) to stop working after a vertical scroll.
Changes:
- Refactored the vertical scroll stabilization logic into a reusable callback.
- Added an
NgZone.isStablefast-path to rundetectChanges()and emitchunkLoadimmediately when the zone is already stable. - Kept the existing
zone.onStable.pipe(first())path for non-stable cases.
Comment on lines
+7775
to
+7779
| if (this.zone.isStable) { | ||
| this.cdr.detectChanges(); | ||
| callback(); | ||
| } else { | ||
| this.zone.onStable.pipe(first()).subscribe(callback); |
Comment on lines
+7775
to
+7779
| if (this.zone.isStable) { | ||
| this.cdr.detectChanges(); | ||
| callback(); | ||
| } else { | ||
| this.zone.onStable.pipe(first()).subscribe(callback); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nkLoad.
Closes #17258
Description
Motivation / Context
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)d