Skip to content

RowEdit + PrimaryKey warning fix - master #5050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 17, 2019
Merged

RowEdit + PrimaryKey warning fix - master #5050

merged 5 commits into from
Jun 17, 2019

Conversation

@ViktorSlavov
Copy link
Contributor

@ViktorSlavov ViktorSlavov commented Jun 12, 2019

Closes #5010

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@ViktorSlavov
fix(grid): fix row editing warning to show when !primaryKey, #5010
e7be078 
# Conflicts:
#	projects/igniteui-angular/src/lib/grids/grid-base.component.ts
damyanpetev
damyanpetev previously approved these changes Jun 13, 2019
View reviewed changes
@Lipata Lipata assigned PlamenaMiteva and unassigned damyanpetev and nrobakova Jun 17, 2019
@PlamenaMiteva PlamenaMiteva added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Jun 17, 2019
@damyanpetev damyanpetev merged commit 18381cf into master Jun 17, 2019
@damyanpetev damyanpetev deleted the vslavov/row-editing-warning-master branch June 17, 2019 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rkaraivanov rkaraivanov rkaraivanov approved these changes

@damyanpetev damyanpetev damyanpetev left review comments

Assignees

@PlamenaMiteva PlamenaMiteva

Labels

grid: general grid: row-editing version: 8.0.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

When rowEditable is set to true in the grid definition the warning for primary key is logged

7 participants

@ViktorSlavov @damyanpetev @rkaraivanov @PlamenaMiteva @nrobakova @kdinev