Skip to content

Conversation

@Aleksandyr
Copy link
Contributor

@Aleksandyr Aleksandyr commented Aug 29, 2019

Closes #5210
Closes #4561

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@Aleksandyr
Copy link
Contributor Author

@simeonoff Could you please consider implementing additional classes for the label as it is handled as a separate component.

I assume that we need three more classes diversifying the left and the right label and it's active state as well.

@simeonoff
Copy link
Collaborator

@simeonoff Could you please consider implementing additional classes for the label as it is handled as a separate component.

I assume that we need three more classes diversifying the left and the right label and it's active state as well.

Added a new class for the label component. The classes are:

  • FROM - igx-slider__label-from
  • TO - igx-slider__label-to
  • FROM ACTIVE - igx-slider__label-from--active
  • TO ACTIVE - igx-slider__label-to--active

simeonoff
simeonoff previously approved these changes Sep 3, 2019
@Aleksandyr
Copy link
Contributor Author

@simeonoff We have introduced the label as a separate component, now it only needs to be aligned and positioned correctly in IE11+
image

@simeonoff simeonoff added ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Sep 10, 2019
@zdrawku zdrawku assigned ddincheva and unassigned nrobakova Sep 10, 2019
@ddincheva ddincheva added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Sep 11, 2019
@zdrawku zdrawku merged commit 103f1df into 8.1.x Sep 11, 2019
@zdrawku zdrawku deleted the slider-label-ie11-8.1.x branch September 11, 2019 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

slider version: 8.1.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants