Skip to content

Fix button group keyboard navigation #5767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 17, 2019
Merged

Fix button group keyboard navigation #5767

merged 6 commits into from
Sep 17, 2019

Conversation

@DiyanDimitrov
Copy link
Contributor

@DiyanDimitrov DiyanDimitrov commented Sep 11, 2019

Closes #5765

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

simeonoff
simeonoff previously approved these changes Sep 11, 2019
View reviewed changes
@tachojelev tachojelev added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Sep 11, 2019
@DiyanDimitrov DiyanDimitrov added 🛠️ status: in-development Issues and PRs with active development on them and removed ✅ status: verified Applies to PRs that have passed manual verification labels Sep 11, 2019
@DiyanDimitrov DiyanDimitrov added ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Sep 11, 2019
@zdrawku zdrawku assigned nrobakova and unassigned tachojelev Sep 12, 2019
@nrobakova nrobakova added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Sep 12, 2019
@zdrawku zdrawku merged commit cb0ce2c into 8.1.x Sep 17, 2019
@zdrawku zdrawku deleted the ddimitrov/fix-5765-8.1.x branch September 17, 2019 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simeonoff simeonoff simeonoff approved these changes

Assignees

@nrobakova nrobakova

Labels

button-group keyboard-navigation version: 8.1.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@DiyanDimitrov @simeonoff @zdrawku @nrobakova @tachojelev