Skip to content

Remove duplicate detectChanges #5810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 17, 2019
Merged

Remove duplicate detectChanges #5810

merged 3 commits into from
Sep 17, 2019

Conversation

@zdrawku
Copy link
Contributor

@zdrawku zdrawku commented Sep 17, 2019

Related to #5787

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@zdrawku zdrawku added 🧱 ci: build CI build related issues and PRs 🧪 ci: tests ci: travis-ci labels Sep 17, 2019
@zdrawku zdrawku changed the title chore(*): Remove duplicate detectChanges Remove duplicate detectChanges Sep 17, 2019
zdrawku added a commit that referenced this pull request Sep 17, 2019
@zdrawku
chore(*): Remove duplicate detectChanges #5810
1a9b283
@zdrawku zdrawku mentioned this pull request Sep 17, 2019
Merged
14 tasks
@zdrawku zdrawku merged commit a9295dc into 8.1.x Sep 17, 2019
@zdrawku zdrawku deleted the update-failing-test branch September 17, 2019 14:18
zdrawku added a commit that referenced this pull request Sep 17, 2019
@zdrawku
Remove duplicate detectChanges #5810 (#5811)
fd491ad 
* tests(fix): update failing tests and fix deprecated warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mpavlinov mpavlinov mpavlinov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nrobakova nrobakova

Labels

🧱 ci: build CI build related issues and PRs ci: travis-ci 🧪 ci: tests version: 8.1.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zdrawku @mpavlinov @nrobakova