Skip to content

perf(grids): limit cell double tap handler to just iOS #5817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2019
Merged

perf(grids): limit cell double tap handler to just iOS #5817

merged 1 commit into from
Sep 17, 2019

Conversation

@damyanpetev
Copy link
Member

@damyanpetev damyanpetev commented Sep 17, 2019

Related to changes made in #5464

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

rkaraivanov
rkaraivanov previously approved these changes Sep 17, 2019
View reviewed changes
@ViktorSlavov ViktorSlavov added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Sep 17, 2019
zdrawku
zdrawku previously approved these changes Sep 17, 2019
View reviewed changes
@damyanpetev damyanpetev dismissed stale reviews from zdrawku and rkaraivanov via 14de710 September 17, 2019 16:23
@damyanpetev damyanpetev force-pushed the dpetev/ios-grid-edit-detect-8.1 branch from d3cbeac to 14de710 Compare September 17, 2019 16:23
@damyanpetev damyanpetev merged commit cd309bf into 8.1.x Sep 17, 2019
@damyanpetev damyanpetev deleted the dpetev/ios-grid-edit-detect-8.1 branch September 17, 2019 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zdrawku zdrawku zdrawku approved these changes

@rkaraivanov rkaraivanov rkaraivanov left review comments

Assignees

@ViktorSlavov ViktorSlavov

Labels

grid: cell-editing grid: general grid: hierarchical-grid grid: tree-grid version: 8.1.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@damyanpetev @zdrawku @rkaraivanov @ViktorSlavov