Bypass all calls to browsers' object when not on browser platform #5938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also reduce wait in nav-drawer test from 2000 -> 200ms Also remove unnecessary checks for isPlatformBrowser in nav-drawer
wnvko
added
nav-drawer
❌ status: awaiting-test
ViktorSlavov
added
💥 status: in-test
damyanpetev
reviewed
Oct 9, 2019
projects/igniteui-angular/src/lib/grids/hierarchical-grid/hierarchical-cell.component.ts
Outdated
Show resolved
Hide resolved
damyanpetev
approved these changes
Oct 9, 2019
zdrawku
deleted the
mvenkov/update-nav-drawer-for-server-side-rendering-8.1.x
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some places in
touch.tsas well as inIgxNavDrawerwhere we were calling browser related things, likerequestAnimationFrame. Now we are checking if there platform where build runs is browser platform. If not, e.g. server side rendering, we skip calling browsers' methods.Closes #4426
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes