Skip to content

Implement select-item text input #6047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Lipata merged 11 commits into from
Oct 28, 2019
Merged

Implement select-item text input #6047

Lipata merged 11 commits into from
Oct 28, 2019

Conversation

@IvayloG
Copy link
Contributor

@IvayloG IvayloG commented Oct 23, 2019 •
edited
Loading

Closes #5989

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@IvayloG IvayloG requested a review from damyanpetev October 23, 2019 14:50
@IvayloG IvayloG changed the title feat(select): Implement select-item text input #5989 Implement select-item text input Oct 24, 2019
@IvayloG IvayloG requested a review from Lipata October 24, 2019 11:07
damyanpetev
damyanpetev previously approved these changes Oct 24, 2019
View reviewed changes
damyanpetev
damyanpetev previously approved these changes Oct 24, 2019
View reviewed changes
@IvayloG
Merge branch 'iganchev/set-text-to-display-master' of https://github.…
da3a429 
…com/IgniteUI/igniteui-angular into iganchev/set-text-to-display-master

# Conflicts:
#	CHANGELOG.md
damyanpetev
damyanpetev previously approved these changes Oct 25, 2019
View reviewed changes
@IvayloG
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular …
404e8e7 
…into iganchev/set-text-to-display-master

# Conflicts:
#	CHANGELOG.md
@wnvko wnvko self-assigned this Oct 25, 2019
@wnvko wnvko added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Oct 25, 2019
@wnvko wnvko removed their assignment Oct 25, 2019
@wnvko wnvko removed their assignment Oct 28, 2019
@Lipata Lipata merged commit c758e68 into master Oct 28, 2019
@Lipata Lipata deleted the iganchev/set-text-to-display-master branch October 28, 2019 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kdinev kdinev kdinev approved these changes

@Lipata Lipata Lipata approved these changes

@damyanpetev damyanpetev damyanpetev approved these changes

Assignees

No one assigned

Labels

select Select component version: 9.0.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

IgxSelect - cannot set text to display for selected items

6 participants

@IvayloG @kdinev @Lipata @damyanpetev @wnvko