refactor(circular-bar): use *ngIf instead of ngClass in progress bar template - 8.1.x #6101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorSlavov
added
❌ status: awaiting-test
ViktorSlavov
force-pushed
the
vslavov/linear-progress-bar-ngIf-8.1.x
branch
from
ff871d8 to
c344f15
Compare
simeonoff
approved these changes
Oct 31, 2019
ViktorSlavov
changed the title
damyanpetev
approved these changes
Oct 31, 2019
PlamenaMiteva
added
💥 status: in-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the progress bar to use
*ngIfinstead ofngClassas the latter requires a specific polyfill and package in order to work in IE (classlist.js).Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes